-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update README.md #50
Conversation
``` | ||
nodejs version 8 or higher | ||
``` | ||
- Support NodeJS >= 14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an issue open about this -- we need to test and ensure everything actually works on another version before we endorse that it's fully functional on anything but node 8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense to pig-pile onto #49 with this particular edit, the rest of this looks fantastic, and we really appreciate it!
I'm with @GaryPWhite on this. If you would like to get it merged, you could remove the node bits and go forward with the rest |
Approved due to the Node update going through in #49 |
Hey @crashmax-dev we are ready to merge this for you as soon as you resolve your conflict. Let us know if you need any help getting this over the line and thank you again for your contribution! |
@Cooperbuilt Maybe there are some other remarks? |
@crashmax-dev looks good to me! Once the pipelines pass we can merge it in |
Proposed Changes
This PR improved README.md
Types of changes
Put an
x
in the boxes that applyFurther comments
Suggest what else can be improved in this PR