Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README.md #50

Merged
merged 3 commits into from
Nov 8, 2021
Merged

Conversation

crashmax-dev
Copy link
Contributor

Proposed Changes

This PR improved README.md

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

Suggest what else can be improved in this PR

```
nodejs version 8 or higher
```
- Support NodeJS >= 14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an issue open about this -- we need to test and ensure everything actually works on another version before we endorse that it's fully functional on anything but node 8.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to pig-pile onto #49 with this particular edit, the rest of this looks fantastic, and we really appreciate it!

@Cooperbuilt
Copy link

I'm with @GaryPWhite on this. If you would like to get it merged, you could remove the node bits and go forward with the rest

@Cooperbuilt
Copy link

Approved due to the Node update going through in #49

@Cooperbuilt
Copy link

Hey @crashmax-dev we are ready to merge this for you as soon as you resolve your conflict. Let us know if you need any help getting this over the line and thank you again for your contribution!

@crashmax-dev
Copy link
Contributor Author

@Cooperbuilt Maybe there are some other remarks?

@Cooperbuilt
Copy link

@crashmax-dev looks good to me! Once the pipelines pass we can merge it in

@Cooperbuilt Cooperbuilt merged commit 0032eb4 into wayfair:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants