Payment services #439
Merged
Payment services #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloCkWeRX
reviewed
Nov 11, 2018
| @payment_services ||= @application.http_get(@application.client, payment_services_endpoint(id)) | ||
| end | ||
|
|
||
| def add_payment_service(id:,payment_service_id:) |
There was a problem hiding this comment.
@CloCkWeRX could you give me an example of proper formatting for named params please. Would this suffice?
def add_payment_service(id:, payment_service_id:)
CloCkWeRX
reviewed
Nov 11, 2018
jono-booth
commented
Nov 16, 2018
CloCkWeRX
approved these changes
Nov 17, 2018
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The payment services end points are not in the public documentation as they are specific to a Partner Applications. You only receive these docs when you become a partner. I chatted to the guys from Xero and they were happy for me to add this to Xeroizer.
Work completed:
Notes:
You cannot POST child records to Branding Themes.
The endpoints are:
GET /BrandingThemes/{BrandingThemeID}/PaymentServices
POST /BrandingThemes/{BrandingThemeID}/PaymentServices
I had to override the relationship helpers in the BrandingTheme model to get this to work. I am interested to know if there is a better way to do this.