Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonarcloud #336

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Sonarcloud #336

merged 7 commits into from
Jan 16, 2025

Conversation

pc-m
Copy link
Member

@pc-m pc-m commented Jun 6, 2024

No description provided.

@pc-m pc-m marked this pull request as ready for review June 6, 2024 16:09
@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/cd595112e2c3409599369863b3815be6

✔️ tox-linters SUCCESS in 8m 52s
✔️ wazo-tox-py39 SUCCESS in 9m 44s
✔️ debian-packaging-bullseye SUCCESS in 3m 00s
❌ auth-tox-integration FAILURE in 13m 19s

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/a7e6f28d648949719f1fbb7834302836

✔️ tox-linters SUCCESS in 8m 10s
✔️ wazo-tox-py39 SUCCESS in 8m 44s
✔️ debian-packaging-bullseye SUCCESS in 2m 50s
❌ auth-tox-integration FAILURE in 13m 00s

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/8a2d79c7d9104bad81bcb3a50e080025

✔️ tox-linters SUCCESS in 8m 12s
✔️ wazo-tox-py39 SUCCESS in 8m 50s
✔️ debian-packaging-bullseye SUCCESS in 3m 02s
❌ auth-tox-integration FAILURE in 13m 14s

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/b8d3c8b737044c45ac80691de5d76401

✔️ tox-linters SUCCESS in 8m 35s
✔️ wazo-tox-py39 SUCCESS in 9m 15s
✔️ debian-packaging-bullseye SUCCESS in 3m 52s
❌ auth-tox-integration FAILURE in 13m 37s

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/78c749e6ca7f4e94b26da4971fc0b81b

✔️ tox-linters SUCCESS in 8m 37s
✔️ wazo-tox-py39 SUCCESS in 9m 12s
✔️ debian-packaging-bullseye SUCCESS in 3m 02s
✔️ auth-tox-integration SUCCESS in 14m 08s

pc-m added 7 commits January 16, 2025 13:54
@pc-m @fblackburn1
remove usage of utcnow
8c08590 
The issue with this function is that is not time zone aware, even if its name would suggest otherwise.
@pc-m @fblackburn1
remove usage of utcfromtimestmap
453a1b7 
The issue with this function is it is not time zone aware, even if its name would suggest otherwise.
@pc-m @fblackburn1
refactor: correct typo in var assignment
77a4f30 
the , in the else should have been a =
since the address_id variable is not used after the if I'm just going to
remove both assignments
@pc-m @fblackburn1
test: typo: remove __ variable reassignment
3050d8a
@pc-m @fblackburn1
refactor: rename self to cls on classmethod
22f8da5
@pc-m @fblackburn1
sonarcloud: add a configuration file
5acf53c
@pc-m @fblackburn1
format the utc timestamps to remove the +00.00
86a50af 
.isoformat() add the tz offset to the timestamp when the datetime object
is tz aware. Having this information is nice but it breaks the API :(
@fblackburn1
Copy link
Member

@pc-m anything blocking to merge this PR?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pc-m pc-m added the mergeit label Jan 16, 2025
@pc-m
Copy link
Member Author

pc-m commented Jan 16, 2025

@pc-m anything blocking to merge this PR?

Yeah, it can be merged. I'll make a new branch if I want to do more changes later

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/5cbf10aeb2784b1797c480bce42e3e41

✔️ tox-linters SUCCESS in 8m 52s
✔️ wazo-tox-py39 SUCCESS in 7m 17s
✔️ debian-packaging-bullseye SUCCESS in 2m 44s
✔️ auth-tox-integration SUCCESS in 12m 57s

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://zuul.wazo.community/zuul/t/local/buildset/bcd6997723bb4ba7a9a9b6ba5355ca61

✔️ tox-linters SUCCESS in 7m 50s
✔️ wazo-tox-py39 SUCCESS in 8m 50s
✔️ debian-packaging-bullseye SUCCESS in 3m 08s
✔️ auth-tox-integration SUCCESS in 12m 40s
✔️ auth-tox-functional SUCCESS in 6m 21s

@wazo-community-zuul wazo-community-zuul bot merged commit 02b58f9 into master Jan 16, 2025
4 checks passed
@wazo-community-zuul wazo-community-zuul bot deleted the sonarcloud branch January 16, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fblackburn1 fblackburn1 fblackburn1 approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pc-m @fblackburn1