Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Wazuh API (NodeJS) installation tasks #330

Merged
merged 11 commits into from
Nov 29, 2019
Merged

Update Wazuh API (NodeJS) installation tasks #330

merged 11 commits into from
Nov 29, 2019

Conversation

rshad
Copy link
Contributor

@rshad rshad commented Nov 21, 2019

Hi all!

This PR resolves #326

Kr,

Rshad

@manuasir manuasir requested a review from jm404 November 21, 2019 14:19
@rshad rshad force-pushed the feature-326-wazuh-api-installation branch from 471e789 to 902ee2a Compare November 22, 2019 10:18
jm404
jm404 suggested changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@jm404 jm404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rshad please have a look at the suggested changes.

playbooks/wazuh-manager.yml Outdated Show resolved Hide resolved
roles/wazuh/ansible-wazuh-manager/tasks/main.yml Outdated Show resolved Hide resolved
roles/wazuh/ansible-wazuh-manager/tasks/main.yml Outdated Show resolved Hide resolved
@rshad rshad self-assigned this Nov 22, 2019
@rshad rshad requested a review from manuasir November 22, 2019 15:55
jm404
jm404 suggested changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@jm404 jm404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rshad, please have a look at the requested changes

roles/wazuh/ansible-wazuh-manager/defaults/main.yml Outdated Show resolved Hide resolved
roles/wazuh/ansible-wazuh-manager/tasks/main.yml Outdated Show resolved Hide resolved
jm404
jm404 approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@jm404 jm404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rshad rshad force-pushed the feature-326-wazuh-api-installation branch from 8a675a6 to e003a2d Compare November 25, 2019 16:39
jm404 pushed a commit that referenced this pull request Nov 25, 2019
Merge #330 from wazuh/ansible
f57840b
@rshad rshad requested a review from manuasir November 26, 2019 09:57
@manuasir manuasir merged commit dc0b787 into devel Nov 29, 2019
@manuasir manuasir deleted the feature-326-wazuh-api-installation branch November 29, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm404 jm404 jm404 approved these changes

@manuasir manuasir Awaiting requested review from manuasir

Assignees

@rshad rshad

Labels
wazuhci/runtests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rshad @manuasir @jm404