Fix Wazuh Agent name conditional in Linux.yml

[jm404]

Hi all,

This PR fixes #333

Best regards,

Jose

[manuasir]

Changes are alright but tests failed.

[rshad]

Hi all!

In 7df7418 we changed the conditional statement is defined to

<target variable> is defined and <target variable> != None

Because having is defined only, would make the execution fail when the target variable has null as a value; In this case, Ansible considers the target variable as defined and as it has null value then it fails when searching for a proper valid value. So adding

<target variable> != None

would ensure that it has a valid value assigned.

Tests

Given the variables:

    wazuh_agent_authd:
      enable: true
      port: 1515
      ssl_agent_ca: null
      ssl_auto_negotiate: 'no'

A test demonstration output is:

TASK [wazuh/ansible-wazuh-agent : Check agent registration via authd output] ***
    ok: [agent-bionic] => {
        "msg": {
            "changed": true, 
            "cmd": "/var/ossec/bin/agent-auth  -m manager-bionic -p 1515      ", 
            "delta": "0:00:00.131941", 
            "end": "2019-12-17 11:36:18.952799", 
            "failed": false, 
            "rc": 0, 
            "start": "2019-12-17 11:36:18.820858", 
            "stderr": "2019/12/17 11:36:18 agent-auth: INFO: Started (pid: 5409).\n2019/12/17 11:36:18 agent-auth: INFO: No authentication password provided.\n2019/12/17 11:36:18 agent-auth: INFO: Connected to 172.18.0.2:1515\n2019/12/17 11:36:18 agent-auth: INFO: Using agent name as: agent-bionic\n2019/12/17 11:36:18 agent-auth: INFO: Send request to manager. Waiting for reply.\n2019/12/17 11:36:18 agent-auth: INFO: Received response with agent key\n2019/12/17 11:36:18 agent-auth: INFO: Valid key created. Finished.\n2019/12/17 11:36:18 agent-auth: INFO: Connection closed.",
            "stderr_lines": [
                "2019/12/17 11:36:18 agent-auth: INFO: Started (pid: 5409).", 
                "2019/12/17 11:36:18 agent-auth: INFO: No authentication password provided.", 
                "2019/12/17 11:36:18 agent-auth: INFO: Connected to 172.18.0.2:1515", 
                "2019/12/17 11:36:18 agent-auth: INFO: Using agent name as: agent-bionic", 
                "2019/12/17 11:36:18 agent-auth: INFO: Send request to manager. Waiting for reply.", 
                "2019/12/17 11:36:18 agent-auth: INFO: Received response with agent key", 
                "2019/12/17 11:36:18 agent-auth: INFO: Valid key created. Finished.", 
                "2019/12/17 11:36:18 agent-auth: INFO: Connection closed."
            ], 
            "stdout": "", 
            "stdout_lines": []
        }
    }

Kr,

Rshad