Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule paths are now relative to playbooks #393

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Rule paths are now relative to playbooks #393

merged 1 commit into from
Mar 24, 2020

Conversation

Zenidd
Copy link
Contributor

@Zenidd Zenidd commented Mar 24, 2020

Hi team,

In the context of wazuh-ansible default playbooks, there were references to roles through absolute paths. These role references are now relative to playbooks.

Greetings,

JP Sáez

@Zenidd Zenidd requested a review from jm404 March 24, 2020 11:52
@Zenidd Zenidd self-assigned this Mar 24, 2020
@Zenidd Zenidd linked an issue Mar 24, 2020 that may be closed by this pull request
Use relative paths when referencing roles etc. #331
Closed
@Zenidd Zenidd marked this pull request as ready for review March 24, 2020 11:52
jm404
jm404 approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@jm404 jm404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jm404 jm404 merged commit f04615c into devel Mar 24, 2020
@jm404 jm404 deleted the feature-331-relative-paths branch March 24, 2020 11:56
@jm404 jm404 mentioned this pull request Mar 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm404 jm404 jm404 approved these changes

Assignees

@Zenidd Zenidd

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use relative paths when referencing roles etc.
2 participants
@Zenidd @jm404