Skip to content

Commit

Permalink
Fix type error on the Agents main view (#4233)
Browse files Browse the repository at this point in the history
* Update CHANGELOG.md

* Update kibana-vis.js

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 7536c05)
  • Loading branch information
chantal-kelm authored and AlexRuiz7 committed Jun 13, 2022
1 parent c3c3c96 commit 06e9210
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to the Wazuh app project will be documented in this file.

## Wazuh v4.3.5 - OpenSearch Dashboards 1.2.0 - Revision 4306

### Fixed

- Fixed type error when changing screen size in agents section [#4233](https://github.com/wazuh/wazuh-kibana-app/pull/4233)
- Fixed an error when generating a module report after changing the selected agent [#4240](https://github.com/wazuh/wazuh-kibana-app/pull/4240)

### Changed

- Changed the word Manager to Wazuh server from the phrases that appeared in "Deploy a new agent". [#4239](https://github.com/wazuh/wazuh-kibana-app/pull/4239)
Expand Down
12 changes: 11 additions & 1 deletion public/kibana-integrations/kibana-vis.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,17 @@ class KibanaVis extends Component {
componentWillUnmount() {
if (this._isMounted) {
this._isMounted = false;
this.updateVis();
// It would be good to continue investigating if it is
// necessary for the renderComplete() to be in the
// componentWillUnmount.
// In the renderComplete() the value of the $rootScope
// is changed, which affects the entire application.
//
// Related issue:
// https://github.com/wazuh/wazuh-kibana-app/issues/4158
if (this.deadField) {
return this.renderComplete();
}
this.destroyAll();
}
}
Expand Down

0 comments on commit 06e9210

Please sign in to comment.