Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HTTP method to POST when using the API login endpoint #3906

Closed
mcarmona99 opened this issue Mar 21, 2022 · 0 comments · Fixed by #4103
Closed

Change HTTP method to POST when using the API login endpoint #3906

mcarmona99 opened this issue Mar 21, 2022 · 0 comments · Fixed by #4103
Assignees

Comments

@mcarmona99
Copy link
Contributor

This issue is part of wazuh/wazuh#12793.

The epic issue aims to change the API login endpoint method from GET to POST, as using GET as the method of a login endpoint is incorrect.

As it was said in wazuh/wazuh#10203 (comment), both GET /security/user/authenticate and POST /security/user/authenticate endpoints will coexist and the deprecation of GET /security/user/authenticate will happen in a future major release.

To avoid future problems when the actual login endpoint (GET) is deprecated, we should update all the references found in this repository:

https://github.com/wazuh/wazuh-kibana-app/blob/0f8c255f57d9505f9d197dae6b9bb28e7cf2cdf9/server/lib/api-interceptor.ts#L49-L60

https://github.com/wazuh/wazuh-kibana-app/blob/0f8c255f57d9505f9d197dae6b9bb28e7cf2cdf9/scripts/generate-api-4.0-info/generate-api-4.0-info.js#L113

Login endpoint inside the GET key in https://github.com/wazuh/wazuh-kibana-app/blob/0f8c255f57d9505f9d197dae6b9bb28e7cf2cdf9/common/api-info/endpoints.json and https://github.com/wazuh/wazuh-kibana-app/blob/0f8c255f57d9505f9d197dae6b9bb28e7cf2cdf9/server/lib/api-request-list.json.

@gdiazlo gdiazlo added the 4.4 label Apr 8, 2022
@mcarmona99 mcarmona99 self-assigned this Apr 26, 2022
@gdiazlo gdiazlo moved this to Triage in Release 4.4.0 Jun 28, 2022
@gdiazlo gdiazlo moved this from Triage to Todo in Release 4.4.0 Jun 28, 2022
@davidjiglesias davidjiglesias moved this from Todo to In Review in Release 4.4.0 Jul 8, 2022
Repository owner moved this from In Review to Done in Release 4.4.0 Jul 11, 2022
@vikman90 vikman90 added this to the Release 4.4.0 milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants