-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use POST method when requesting the API login endpoint #4103
Conversation
…into feature/3906-post-login-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review
code ✔️
test ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✔️
Test: ✔️
* Use POST method when requesting the API login endpoint * changelog: add PR entry Co-authored-by: Matias Ezequiel Moreno <matiasmoreno876@gmail.com> Co-authored-by: Álex <alex-r-b@hotmail.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 3977e45)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-1.2-wzd 4.4-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.4-1.2-wzd
# Create a new branch
git switch --create backport-4103-to-4.4-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3977e45c6ffdc06926edfd12355f0f20dd2f9d84
# Push it to GitHub
git push --set-upstream origin backport-4103-to-4.4-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-1.2-wzd Then, create a pull request where the |
* Use POST method when requesting the API login endpoint * changelog: add PR entry Co-authored-by: Matias Ezequiel Moreno <matiasmoreno876@gmail.com> Co-authored-by: Álex <alex-r-b@hotmail.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 3977e45)
* Use POST method when requesting the API login endpoint * changelog: add PR entry Co-authored-by: Matias Ezequiel Moreno <matiasmoreno876@gmail.com> Co-authored-by: Álex <alex-r-b@hotmail.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 3977e45) Co-authored-by: Manuel Carmona Pérez <manuelvillarcarmona@gmail.com>
…point (#4319) Use POST method when requesting the API login endpoint (#4103) * Use POST method when requesting the API login endpoint * changelog: add PR entry Co-authored-by: Matias Ezequiel Moreno <matiasmoreno876@gmail.com> Co-authored-by: Álex <alex-r-b@hotmail.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 3977e45) Co-authored-by: Manuel Carmona Pérez <manuelvillarcarmona@gmail.com>
* Use POST method when requesting the API login endpoint * changelog: add PR entry Co-authored-by: Matias Ezequiel Moreno <matiasmoreno876@gmail.com> Co-authored-by: Álex <alex-r-b@hotmail.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 3977e45) Co-authored-by: Manuel Carmona Pérez <manuelvillarcarmona@gmail.com>
* Use POST method when requesting the API login endpoint * changelog: add PR entry Co-authored-by: Matias Ezequiel Moreno <matiasmoreno876@gmail.com> Co-authored-by: Álex <alex-r-b@hotmail.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 3977e45) Co-authored-by: Manuel Carmona Pérez <manuelvillarcarmona@gmail.com>
This PR closes #3906.
In this pull request, I have changed the method used when requesting the API login endpoint from GET to POST because as it was said in the related issue, the actual login endpoint (GET) is going to be deprecated.
New generate-api-4.0-info.js output (it works with the new changes):