Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use POST method when requesting the API login endpoint #4103

Merged
merged 5 commits into from
Jul 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

All notable changes to the Wazuh app project will be documented in this file.

## Wazuh v4.4.0 - Kibana 7.10.2, 7.16.x, 7.17.x - Revision 4400

### Changed

- Changed the HTTP verb from `GET` to `POST` in the requests to login to the Wazuh API [#4103](https://github.com/wazuh/wazuh-kibana-app/pull/4103)

## Wazuh v4.3.5 - Kibana 7.10.2, 7.16.x, 7.17.x - Revision 4306

### Added
Expand Down
40 changes: 20 additions & 20 deletions common/api-info/endpoints.json
Original file line number Diff line number Diff line change
Expand Up @@ -6904,25 +6904,6 @@
}
]
},
{
"name": "/security/user/authenticate",
"documentation": "https://documentation.wazuh.com/current/user-manual/api/reference.html#operation/api.controllers.security_controller.login_user",
"description": "This method should be called to get an API token. This token will expire after auth_token_exp_timeout seconds (default: 900). This value can be changed using PUT /security/config",
"summary": "Login",
"tags": [
"Security"
],
"query": [
{
"name": "raw",
"description": "Format response in plain text",
"required": false,
"schema": {
"type": "boolean"
}
}
]
},
{
"name": "/security/users",
"documentation": "https://documentation.wazuh.com/current/user-manual/api/reference.html#operation/api.controllers.security_controller.get_users",
Expand Down Expand Up @@ -10851,6 +10832,25 @@
}
]
},
{
"name": "/security/user/authenticate",
"documentation": "https://documentation.wazuh.com/current/user-manual/api/reference.html#operation/api.controllers.security_controller.login_user",
"description": "This method should be called to get an API token. This token will expire after auth_token_exp_timeout seconds (default: 900). This value can be changed using PUT /security/config",
"summary": "Login",
"tags": [
"Security"
],
"query": [
{
"name": "raw",
"description": "Format response in plain text",
"required": false,
"schema": {
"type": "boolean"
}
}
]
},
{
"name": "/security/user/authenticate/run_as",
"documentation": "https://documentation.wazuh.com/current/user-manual/api/reference.html#operation/api.controllers.security_controller.run_as_login",
Expand Down Expand Up @@ -12010,4 +12010,4 @@
}
]
}
]
]
5 changes: 3 additions & 2 deletions scripts/generate-api-4.0-info/generate-api-4.0-info.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const main = () => {
if(!WAZUH_API_URL.startsWith('http') ){
exitWithMessage(`Wazuh API url is not valid. It should start with "http". Example: https://172.16.1.2:55000`);
};

// Log the configuration:
console.log('--------------- Configuration ---------------');
console.log(`Wazuh API url: ${WAZUH_API_URL}`);
Expand Down Expand Up @@ -111,6 +111,7 @@ const generateAPISecurityActionsInformation = async () => {
const password = 'wazuh';
try{
const authenticationResponse = await request(`${WAZUH_API_URL}/security/user/authenticate`, {
method: 'POST',
headers: {
'Authorization': 'Basic ' + Buffer.from(username + ':' + password).toString('base64')
}
Expand All @@ -119,7 +120,7 @@ const generateAPISecurityActionsInformation = async () => {
const { token } = JSON.parse(authenticationResponse).data;
const securityActionsResponse = await request(`${WAZUH_API_URL}/security/actions`, {
headers: {
'Authorization': `Bearer ${token}`
'Authorization': `Bearer ${token}`
}
});
const securityActions = JSON.parse(securityActionsResponse).data;
Expand Down
4 changes: 2 additions & 2 deletions server/lib/api-interceptor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { ManageHosts } from './manage-hosts';
import https from 'https';

const httpsAgent = new https.Agent({
rejectUnauthorized: false,
rejectUnauthorized: false,
});

const _axios = axios.create({ httpsAgent });
Expand Down Expand Up @@ -47,7 +47,7 @@ export const authenticate = async (apiHostID: string, authContext?: any): Promis
try{
const api: APIHost = await manageHosts.getHostById(apiHostID);
const optionsRequest = {
method: !!authContext ? 'POST' : 'GET',
method: 'POST',
headers: {
'content-type': 'application/json',
},
Expand Down
40 changes: 20 additions & 20 deletions server/lib/api-request-list.json
Original file line number Diff line number Diff line change
Expand Up @@ -6878,25 +6878,6 @@
}
]
},
{
"name": "/security/user/authenticate",
"documentation": "https://documentation.wazuh.com/current/user-manual/api/reference.html#operation/api.controllers.security_controller.login_user",
"description": "This method should be called to get an API token. This token will expire after auth_token_exp_timeout seconds (default: 900). This value can be changed using PUT /security/config",
"summary": "Login",
"tags": [
"Security"
],
"query": [
{
"name": "raw",
"description": "Format response in plain text",
"required": false,
"schema": {
"type": "boolean"
}
}
]
},
{
"name": "/security/users",
"documentation": "https://documentation.wazuh.com/current/user-manual/api/reference.html#operation/api.controllers.security_controller.get_users",
Expand Down Expand Up @@ -10503,6 +10484,25 @@
}
]
},
{
"name": "/security/user/authenticate",
"documentation": "https://documentation.wazuh.com/current/user-manual/api/reference.html#operation/api.controllers.security_controller.login_user",
"description": "This method should be called to get an API token. This token will expire after auth_token_exp_timeout seconds (default: 900). This value can be changed using PUT /security/config",
"summary": "Login",
"tags": [
"Security"
],
"query": [
{
"name": "raw",
"description": "Format response in plain text",
"required": false,
"schema": {
"type": "boolean"
}
}
]
},
{
"name": "/security/user/authenticate/run_as",
"documentation": "https://documentation.wazuh.com/current/user-manual/api/reference.html#operation/api.controllers.security_controller.run_as_login",
Expand Down Expand Up @@ -11662,4 +11662,4 @@
}
]
}
]
]