Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement try catch strategy ManagementController #3374

Merged
merged 12 commits into from
Jun 30, 2021

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Jun 16, 2021

Hi team,
This PR implement our new error handling strategy on ManagementController

Close: #3396

@Machi3mfl Machi3mfl self-assigned this Jun 16, 2021
@Machi3mfl Machi3mfl requested a review from a team June 16, 2021 16:10
Machi3mfl and others added 5 commits June 17, 2021 15:57
* Added lowercase levels in storeError

* Updated CHANGELOG

Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
* refactor in vulnerabilities table component

* refactor code in vuls inventory and add new table component with export csv

* adapat table

* finished refactor table component

* delete console logs and fix wrong version

* add new fields in suggestions

* add changelog

* changes in component table and remove status and type columns

* fix columns position

* feat(mitre): Add Mitre Att&ck intelligence section
  - Created Intelligence tab in Mitre Att&ck Module
  - Created left and right panel
  - Created resource button for the left panel
  - Created search bar for searhin in all resources
  - Created list of each resource

* feat(mitre_intelligence): Modify the search results view and another
improvements
  - Modify the Search results view
  - Improve useAsyncAction hook
  - Add Mitre Att&ck Intelligence to Agent modules component
  - Improve TableWithSearchBar component to accept filters as props
  - Refactor Mitre Atta&ck resources
  - Refator PanelSplit component
  - Fix filtersToObject helper
  - Update test

* feat(mitre_att&ck_intelligence): Render description as markdown
  - Create Markdown component
  - Apply the Markdown component to the resource description in the resouce table

* feat(mitre_atta&ck_intelligence): Add like operator to search resource
by description

* change endpoint and adapt component in mitre

* fix flyout

* feat(mirte_att&ck_integillence): Add the References resource
  - Added to left panel
  - Added resource view

* add redirect to intelligence

* fix merge

* fix merge flyout

* fix package version

* fix(mitre_att&ck_intelligence): Organize resource suggestions and remove Reference resource

* fix PR comments and add intelligence section redirect

* Created new Mitre flyout

* Changelog

* fix comments PR

* add redirect values in query params

* apply prettier

* Resolving comments and upgrading code

* Applying comments upgrades to references table

* Applying more upgrade comments

* fix(mitre_intelligence): Remove the Promise.reject in resource details flyout

* clear comments and imports

* fix error handler techniques

* delete session storage

* delete files and fix get techniques data

* Created new Mitre flyout (#3344)

* Created new Mitre flyout

* Changelog

* Erasing comments

* Erasing console.log

* Resolving comments and upgrading code

* Applying comments upgrades to references table

* Applying more upgrade comments

* fix(mitre_intelligence): Remove the Promise.reject in resource details flyout

Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>

* fix redirect flyout to rules

* feat(frontend/mitre_att&ck_intelligence): Removed welcome intelligence
  - Removed welcome intelligence view and adjustments when doing a general search
  - Set a resource type as selected
  - Update test

* fix comments PR

* fix(mitre_att&ck_intelligence): Change how to open the resource details flyout
  - Change how to open the resource details flyout
  - Refactor some componentes properties
  - Removed not used code

* changelog: Added PR to chengelog

* Update CHANGELOG.md

* fix(mitre_att&ck_intelligence): Fix error in table-default.tsx

* fix(mitre_att&ck_intelligence): PR request changes:
  - Add tests for:
    - Components: Markdown, PanelSplit
    - React Hooks: useAsyncAction
  - Renamed files
  - Add justification for using dangerouslySetInnerHTML property
  - Refactor requests to get mitre techniques
  - Fix tooltips to open tactic/technique details in Framework
  - Added some missing semicolon
  - Fix CSS class wz-markdown-wrapper name

* fix get mitre Techniques from api

Co-authored-by: eze9252 <eze9252@gmail.com>
Co-authored-by: CPAlejandro <cuellarpeinado@gmail.com>
Co-authored-by: Alejandro Cuéllar Peinado <alejandro.cuellar@wazuh.com>
Co-authored-by: Ezequiel Airaudo <36004787+eze9252@users.noreply.github.com>
Co-authored-by: Franco Charriol <franco.charriol@wazuh.com>
* feat(error-orchestrator): Improved on createGetterSetter

* bugfix(error-orchestrator): Added default value of disaply and store, remove location of types and fixed toastMessage of addError

* feat(error-orchestrator): Added creatorGetterSetter on wazuh-app to avoid dependence on Kibana.
@Machi3mfl Machi3mfl requested a review from a team June 22, 2021 18:05
public/controllers/management/management.js Outdated Show resolved Hide resolved
public/controllers/management/management.js Outdated Show resolved Hide resolved
public/controllers/management/management.js Outdated Show resolved Hide resolved
public/controllers/management/management.js Outdated Show resolved Hide resolved
public/controllers/management/management.js Outdated Show resolved Hide resolved
@Machi3mfl Machi3mfl changed the base branch from feature/3265-implement-try-catch-frontend to 4.3-7.10 June 22, 2021 19:59
@gabiwassan gabiwassan requested review from Desvelao and frankeros June 24, 2021 19:07
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabiwassan gabiwassan merged commit 57c6259 into 4.3-7.10 Jun 30, 2021
@gabiwassan gabiwassan deleted the feature/3265-implement-try-catch-management-ctrl branch June 30, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants