-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix creation of log files #3384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
CD ✅
Testting ✅
this.PLAIN_LOGS_PATH = path.join(WAZUH_DATA_LOGS_DIRECTORY_PATH, plainLogsFile); | ||
this.RAW_LOGS_PATH = path.join(WAZUH_DATA_LOGS_DIRECTORY_PATH, rawLogsFile); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought:: Could we move the variable that stores the path of these files to the constants.ts
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
issue: The filename looks a little bit weird. suggestion: Here it is the filename had before the changes: https://github.com/wazuh/wazuh-kibana-app/blob/12ad00eedf03e6625493b05d8ba9a9e6fff48a4e/server/lib/logger.ts#L105-L108
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review
Code review: ✅
Testing: ✅
Hi team this PR solves a problem related with the creation of the log files, adding a condition that if the file does not exist it will be created. Also solves a problem with the rotation of the log file if it's size is over 100MB.