Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Don't open the main menu when changing the selected API or index pattern #3440

Merged
merged 3 commits into from
Jul 20, 2021
Merged

[FIX] Don't open the main menu when changing the selected API or index pattern #3440

merged 3 commits into from
Jul 20, 2021

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jul 6, 2021

Description

Don't open the main menu when changing the selected API or index pattern using the selectors

Test

  • Change API shouldn't open the main menu
  • Change the Index pattern shouldn't open the main menu

Closes: #3351

@Desvelao Desvelao added the type/bug Bug issue label Jul 6, 2021
@Desvelao Desvelao self-assigned this Jul 6, 2021
@Desvelao Desvelao changed the title fix(frontend): Doesn't open menu when changing the API or Index patte… [FIX] Doesn't open the main menu when changing the selected API or index pattern Jul 6, 2021
frankeros
frankeros approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM!

@Desvelao Desvelao linked an issue Jul 6, 2021 that may be closed by this pull request
Wazuh main menu opens when selecting new api #3351
Closed
@Desvelao Desvelao changed the title [FIX] Doesn't open the main menu when changing the selected API or index pattern [FIX] Don't open the main menu when changing the selected API or index pattern Jul 6, 2021
mpRegalado
mpRegalado approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@mpRegalado mpRegalado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM! ✔️

pablomarga
pablomarga approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing: ✔️
CR ✔️

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.12% ( 1109 / 35594 )
Branches 1.16% ( 324 / 27961 )
Functions 2.02% ( 174 / 8632 )
Lines 3.15% ( 1071 / 34012 )

@MauGaP MauGaP merged commit 0ef9eea into 4.3-7.10 Jul 20, 2021
@MauGaP MauGaP deleted the fix/3351-api-index-pattern-selectors-opens-menu-when-selecting branch July 20, 2021 13:11
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
@MauGaP MauGaP mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpRegalado mpRegalado mpRegalado approved these changes

@pablomarga pablomarga pablomarga approved these changes

@frankeros frankeros frankeros approved these changes

Assignees

@Desvelao Desvelao

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wazuh main menu opens when selecting new api
5 participants
@Desvelao @frankeros @pablomarga @mpRegalado @MauGaP