Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error when edit a rule or decoder #3456

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Fixed error when edit a rule or decoder #3456

merged 3 commits into from
Jul 21, 2021

Conversation

Machi3mfl
Copy link
Member

Hi team.
This PR fixes a bug that occurs when edit and save a rule or decoder.
Also, the save button does not stop loading.

Close #3455

@Machi3mfl Machi3mfl requested a review from a team July 8, 2021 17:57
@Machi3mfl Machi3mfl self-assigned this Jul 8, 2021
@Machi3mfl
Copy link
Member Author

Testing fix in Rules

Screen.Recording.2021-07-08.at.14.35.39.mov

Testing fix in Decoders

Screen.Recording.2021-07-08.at.14.36.43.mov

gabiwassan
gabiwassan approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

frankeros
frankeros approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.66% ( 1304 / 35653 )
Branches 1.46% ( 409 / 28083 )
Functions 2.56% ( 221 / 8616 )
Lines 3.7% ( 1260 / 34089 )

@MauGaP MauGaP merged commit 8e34e86 into 4.3-7.10 Jul 21, 2021
@MauGaP MauGaP deleted the bugfix/3455-error-saving-editing-rules-decoders branch July 21, 2021 11:59
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
@MauGaP MauGaP mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankeros frankeros frankeros approved these changes

@gabiwassan gabiwassan gabiwassan approved these changes

Assignees

@Machi3mfl Machi3mfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Machi3mfl @gabiwassan @frankeros @MauGaP