[FEAT] Refactor the layout of modules #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and view are redered. - Moved view to each tab in tab for each module - Now each module tab defines its buttons to display in the header - Adapted custom tab components adding the `withAgentSupportModule` - Created and refactor the logic of `Loader` component to a HOC `withModuleTabLoader` - Removed `Settings` and `Loader` components duw to are not used - Removed not used imports
- Refactor `Explore agent` button - Added `availabeFor` propery to `modules-defaults.json` used by `Explore agent` button. - Created `PromptModuleNotForAgent` component - Created `withModuleNotForAgent` HOC - Removed no used code and use component props intead use `store` in `public/components/common/modules/main.tsx`
…into feat/3485-enhance-module-tab-buttons
|
When generation a report in Security Events this error is displayed in the dev tools console |
mpRegalado
approved these changes
Aug 4, 2021
|
|
||
| export const PromptModuleNotForAgent = ({ body, title, ...agentSelectionProps }: PromptSelectAgentProps) => { | ||
| const dispatch = useDispatch(); | ||
| const filterManager = useFilterManager(); |
There was a problem hiding this comment.
This has changed in the office365 branch. Noting it so we are mindful when merging there.
CPAlejandro
reviewed
Aug 6, 2021
|
Changes applied:
|
…nd `with_module_tab_loader.tsx`
….com/wazuh/wazuh-kibana-app into feat/3485-enhance-module-tab-buttons
…into feat/3485-enhance-module-tab-buttons
Changes
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
modules-defaults.jsto define what buttons and components are rendered in each module tab.Explore agentbutton fromModules/MITRE ATT&CK/Intelligence.PromptModuleNotForAgentcomponent.withModuleNotForAgentHOC.Tests
Explore agentis working as usual.Generate reportis working as usual.Modules/MITRE ATT&CK/Intelligenceis not displaying theExplore agentbutton.Closes #3485