Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UseValueSuggestions hook #3506

Merged
merged 6 commits into from
Jul 28, 2021
Merged

UseValueSuggestions hook #3506

merged 6 commits into from
Jul 28, 2021

Conversation

mpRegalado
Copy link
Member

closes #3500

This hook gets value suggestions for the provided field.
It uses

  • filterField : The name of the field to get values for
  • type : either 'string' or 'boolean', the kind of field requested.

It returns:

  • suggestedValues : array of possible values
  • isLoading : updates on the loading state
  • setQuery : Setting the query string will update the suggestedValues to match

@mpRegalado mpRegalado requested a review from a team July 28, 2021 11:01
@mpRegalado mpRegalado self-assigned this Jul 28, 2021
@mpRegalado mpRegalado linked an issue Jul 28, 2021 that may be closed by this pull request
Dynamically generate options for filter menu #3500
Closed
asteriscos
asteriscos approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️

CPAlejandro
CPAlejandro approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@CPAlejandro CPAlejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM!

Desvelao
Desvelao approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:
Code review ✅

gabiwassan
gabiwassan approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@mpRegalado mpRegalado merged commit 8f5794e into feature/Office365 Jul 28, 2021
@mpRegalado mpRegalado deleted the enhancement/3500_useValueSuggestions branch July 28, 2021 14:14
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@CPAlejandro CPAlejandro CPAlejandro approved these changes

@gabiwassan gabiwassan gabiwassan approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@mpRegalado mpRegalado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamically generate options for filter menu
5 participants
@mpRegalado @asteriscos @gabiwassan @CPAlejandro @Desvelao