Module Office 365 configuration viewer #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabiwassan
requested review from
frankeros,
Desvelao,
eze9252,
mpRegalado and
CPAlejandro
frankeros
reviewed
Aug 2, 2021
...components/management/configuration/office365/components/SubscriptionTab/SubscriptionTab.tsx
Outdated
Show resolved
Hide resolved
...agement/components/management/configuration/office365/components/general-tab/general-tab.tsx
Outdated
Show resolved
Hide resolved
public/controllers/management/components/management/configuration/office365/constants.tsx
Outdated
Show resolved
Hide resolved
public/controllers/management/components/management/configuration/office365/office365.tsx
Outdated
Show resolved
Hide resolved
…ot. Fix label of only_future_events
Desvelao
reviewed
Aug 4, 2021
...ement/components/management/configuration/office365/components/api-auth-tab/api-auth-tab.tsx
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
Aug 4, 2021
public/controllers/management/components/management/configuration/office365/office365.tsx
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
Aug 4, 2021
...ement/components/management/configuration/office365/components/api-auth-tab/api-auth-tab.tsx
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
Aug 4, 2021
| field: 'only_future_events', | ||
| label: 'Collect events generated since Wazuh is initialized', | ||
| }, | ||
| { field: 'interval', label: 'Interval between Office 365 wodle executions in seconds' }, |
There was a problem hiding this comment.
check: We should check if the value of interval is expressed in seconds on the API response because the field description mentions the time is in seconds.
There was a problem hiding this comment.
Maybe like this:
Interval between Office 365 wodle executions, format: s (seconds), m (minutes), h (hours), d (days)
There was a problem hiding this comment.
issue: I could not test the PR, but I think the time could be returned in seconds. Check it.
Desvelao
reviewed
Aug 4, 2021
...ement/components/management/configuration/office365/components/api-auth-tab/api-auth-tab.tsx
Outdated
Show resolved
Hide resolved
mpRegalado
approved these changes
Aug 6, 2021
|
Second test: |
|
review: |
…viewer - Module configuration only available for managers - Replaced as the list of credentials are rendered. Now it uses the `WzConfigurationSettingsListSelector` - Replaced some descriptions
Changes
Screenshot
|
mpRegalado
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team
This PR added configuration on
Management/Configurationfor the new module Office 365.XML config extracted from issue #4983 and PR
Screenshots:
Management/Configuration
Office 365 / General:
Office 365 / Api Auth:
Office 365 / Subscriptions:
JSON/XML:
Closes: #3507
Note: we have not yet defined URLs documentation