Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pagination drilldown tables #3544

Merged
merged 5 commits into from
Aug 9, 2021

Conversation

CPAlejandro
Copy link
Contributor

Hi guys,

In this PR we switch from basic tables to memory tables to be able to show the paginated tables.

image

To test it we will only have to get into the Office module and go to the Panel tab

@CPAlejandro CPAlejandro self-assigned this Aug 6, 2021
@sortiz1191 sortiz1191 self-requested a review August 6, 2021 08:48
Copy link
Contributor

@sortiz1191 sortiz1191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: 🟢
CR: 🟢

Copy link
Contributor

@eze9252 eze9252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CPAlejandro CPAlejandro requested a review from mpRegalado August 9, 2021 09:38
Copy link
Member

@mpRegalado mpRegalado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM ✔️
Testing : LGTM ✔️

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:
Code review ✅
Testing ✅

@Desvelao Desvelao merged commit 1763581 into feature/Office365 Aug 9, 2021
@Desvelao Desvelao deleted the feature/Pagination-drilldown-tables branch August 9, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants