Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-select component searcher handler #3645

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Multi-select component searcher handler #3645

merged 4 commits into from
Nov 30, 2021

Conversation

gabiwassan
Copy link
Contributor

@gabiwassan gabiwassan commented Oct 6, 2021 •
edited
Loading

Hi team,
This PR fixes the behavior when trying to search for new items with selected items.

Testing:

  • Select some items of the multiselect component.
  • Search on input and select another item.

Example of wrong behaviour:
Peek 2021-09-03 18-28

Close: #3608

@gabiwassan gabiwassan self-assigned this Oct 6, 2021
@gabiwassan gabiwassan requested a review from a team October 7, 2021 11:55
Machi3mfl
Machi3mfl approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅
Test ✅

@gabiwassan gabiwassan requested a review from frankeros October 13, 2021 11:16
CPAlejandro
CPAlejandro reviewed Oct 15, 2021
View reviewed changes
Copy link
Contributor

@CPAlejandro CPAlejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add this PR to the Changelog.md

CPAlejandro
CPAlejandro approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@CPAlejandro CPAlejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM!

Base automatically changed from feat/3372-github-module to 4.3-7.10 November 15, 2021 08:55
@Machi3mfl Machi3mfl added the 4.3 label Nov 30, 2021
@MauGaP MauGaP changed the base branch from 4.3-7.10 to 4.3-7.10---RC1 November 30, 2021 14:13
@MauGaP MauGaP merged commit 7ac2586 into 4.3-7.10---RC1 Nov 30, 2021
@MauGaP MauGaP deleted the fix/3608-multiselect-component-handler branch November 30, 2021 14:15
@MauGaP MauGaP mentioned this pull request Dec 1, 2021
Closed
@MauGaP MauGaP mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPAlejandro CPAlejandro CPAlejandro approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@frankeros frankeros Awaiting requested review from frankeros

Assignees

@gabiwassan gabiwassan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gabiwassan @Machi3mfl @CPAlejandro @frankeros @MauGaP