Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete wazuh token called twice #3652

Merged
merged 4 commits into from
Nov 5, 2021
Merged

Delete wazuh token called twice #3652

merged 4 commits into from
Nov 5, 2021

Conversation

frankeros
Copy link
Contributor

@frankeros frankeros commented Oct 18, 2021 •
edited by CPAlejandro
Loading

Hi team, this resolves

  • Delete wazuh token is called twice

Testing:

To test it:

Precondition 1: Location: public/react-services/wz-authentication.ts#L151

  1. Go to Inventory Section of an agent
  • Given the browser is logged in the Wazuh kibana app
  • When the put a console log in Precondition 1
  • And the user will logged out
  • Then the console log will appear properly in the browser console

CPAlejandro
CPAlejandro approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@CPAlejandro CPAlejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM!
Testing: I have tested it with Firefox and Chrome and it seems to work fine!

asteriscos
asteriscos approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
Tested with and without the changes.

CR: ✔️

@frankeros frankeros changed the base branch from 4.3-7.10 to 4.2-7.10 October 21, 2021 12:26
@frankeros frankeros changed the base branch from 4.2-7.10 to 4.3-7.10 October 21, 2021 12:26
@frankeros frankeros merged commit 37d649e into 4.3-7.10 Nov 5, 2021
@frankeros frankeros deleted the fix/delete-wazuh-token-called-twice branch November 5, 2021 13:09
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
@MauGaP MauGaP mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPAlejandro CPAlejandro CPAlejandro approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankeros @asteriscos @CPAlejandro