Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed security alerts table when filters change #3682

Merged

Conversation

Machi3mfl
Copy link
Member

Hi Team,
This PR resolves the security alerts table not refreshing when filters change.
Closes #3648

Machi3mfl and others added 13 commits October 21, 2021 11:50
* Fixed compatibility wazuh 4.2 - kibana 7.13.4

* Changed xDomain in elastic chart

* Added await in getSearchRequestBody

* Updated CHANGELOG

Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
Co-authored-by: Franco Charriol <franco.charriol@wazuh.com>
* Fixed interative register windows agent screen error

* Added toLowercase

* Updated CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
Co-authored-by: Franco Charriol <franco.charriol@wazuh.com>
* changed import of saved searches

* local copy of legacy/vis_update_state
* Parcial breadcrumb style fix

* Improved beadcrumb styling and text overflow

* Added changelog
…3674)

* Fixing EuiPannels in Overview Sections

* Fixing disabled text in Wz Menu
* Fixing disabled buttons in wz menu

* Fixing double flyout
…ying to going back after you save (#3672)

* Solving error

* Adding Changelog.md

* Fixing bug editting user
…in Kibana 7.10.2 - 7.13.4 (#3681)

* fix(compatibility): Manage how to get the index pattern data and refresh
the fields for Kibana 7.10.2 and Kibana >=7.11.0
  - Added a function to check if the Kibana version (`kibana.version`
property of `package.json`) satisfies a specific version.
  - Modified some logic when getting the index patterns or refreshing
them to be compatible with 7.10.2 and 7.13.4. An Kibana change modified
as getting the index pattern fields.
  - Added a toast when an unknown index pattern field is detected in
Kibana >7.10.2 in Modules/<MODULE>/(Dashboard/Events) and set its life
time to 5 minutes.

Note: tested with Kibana 7.10.2 and 7.13.4 but should works in Kibana
7.11.x and 7.12.x

* changelog: Add PR to changelog

* fix(compatibility): Replaced references from 7.10.2 to 7.11 in the fixes for the compatibility to get the index pattern data and their fields and refresh them
@Machi3mfl Machi3mfl requested a review from a team November 10, 2021 19:38
Copy link
Contributor

@eze9252 eze9252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Testing: ✅
🦖

@Machi3mfl Machi3mfl changed the base branch from 4.2-7.10 to 4.3-7.10 November 29, 2021 13:54
@Machi3mfl Machi3mfl changed the base branch from 4.3-7.10 to 4.2-7.10 November 29, 2021 14:01
@Machi3mfl Machi3mfl changed the base branch from 4.2-7.10 to 4.3-7.10 November 29, 2021 14:02
@Machi3mfl Machi3mfl changed the base branch from 4.3-7.10 to 4.2-7.10 November 29, 2021 14:03
@Machi3mfl Machi3mfl changed the base branch from 4.2-7.10 to 4.3-7.10 November 29, 2021 14:03
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.97% ( 1444 / 36388 )
Branches 1.59% ( 453 / 28431 )
Functions 2.91% ( 259 / 8896 )
Lines 4.02% ( 1399 / 34773 )

@Machi3mfl Machi3mfl added the 4.3 label Nov 30, 2021
@MauGaP MauGaP changed the base branch from 4.3-7.10 to 4.3-7.10---RC1 November 30, 2021 14:03
@MauGaP MauGaP changed the title Update security alerts table when filters change Fixed security alerts table when filters change Nov 30, 2021
@MauGaP MauGaP merged commit 3627594 into 4.3-7.10---RC1 Nov 30, 2021
@MauGaP MauGaP deleted the bugfix/3648-security-alerts-table-filters-changes branch November 30, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants