Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error on the Agents main view #4233

Merged
merged 8 commits into from
Jun 13, 2022
+12 −2
Merged

Fix type error on the Agents main view #4233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
80bbe65
solution
chantal-kelm Jun 8, 2022
6327d45
comment
chantal-kelm Jun 8, 2022
9b82e71
changelog
chantal-kelm Jun 8, 2022
4a1142e
changelog
chantal-kelm Jun 9, 2022
8243798
Merge branch '4.3-7.10' into fix/4158-TypeError-Agents-main-view
AlexRuiz7 Jun 13, 2022
0b2ba02
Update CHANGELOG.md
AlexRuiz7 Jun 13, 2022
6c7b54d
Update kibana-vis.js
AlexRuiz7 Jun 13, 2022
4643d60
Merge branch '4.3-7.10' into fix/4158-TypeError-Agents-main-view
AlexRuiz7 Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ All notable changes to the Wazuh app project will be documented in this file.

## Wazuh v4.3.5 - Kibana 7.10.2, 7.16.x, 7.17.x - Revision 4306


### Fixed

- Fixed type error when changing screen size in agents section [#4233](https://github.com/wazuh/wazuh-kibana-app/pull/4233)
- Fixed an error when generating a module report after changing the selected agent [#4240](https://github.com/wazuh/wazuh-kibana-app/pull/4240)

### Changed
Expand Down
12 changes: 11 additions & 1 deletion public/kibana-integrations/kibana-vis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,17 @@ class KibanaVis extends Component {
componentWillUnmount() {
if (this._isMounted) {
this._isMounted = false;
this.updateVis();
// It would be good to continue investigating if it is
// necessary for the renderComplete() to be in the
// componentWillUnmount.
// In the renderComplete() the value of the $rootScope
// is changed, which affects the entire application.
//
// Related issue:
// https://github.com/wazuh/wazuh-kibana-app/issues/4158
if (this.deadField) {
return this.renderComplete();
}
this.destroyAll();
}
}
Expand Down