Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting by agents in the table groups #4323

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

yenienserrano
Copy link
Member

Description:

Added the option to sort by agents in the group table.

Issue:

Preconditions:

Have more than 1 group with different numbers of agents

Test:

  1. Navigate to "Management/Groups"
  2. Click on "Agents"
  3. See that they are sorted by number of agents

Screenshot:

image
image

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Screenshot from 2022-07-14 12-55-07
Screenshot from 2022-07-14 12-55-16

Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@AlexRuiz7 AlexRuiz7 merged commit 9079f07 into 4.4-7.10 Jul 18, 2022
@AlexRuiz7 AlexRuiz7 deleted the fix/3950-sorting-by-agents-in-the-table-groups branch July 18, 2022 10:37
github-actions bot pushed a commit that referenced this pull request Jul 18, 2022
* Added sortable by agent count option to the groups table

* Added changelog entry

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 9079f07)
github-actions bot pushed a commit that referenced this pull request Jul 18, 2022
* Added sortable by agent count option to the groups table

* Added changelog entry

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 9079f07)
AlexRuiz7 pushed a commit that referenced this pull request Jul 18, 2022
Sorting by agents in the table groups (#4323)

* Added sortable by agent count option to the groups table

* Added changelog entry

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 9079f07)

Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
AlexRuiz7 pushed a commit that referenced this pull request Jul 18, 2022
Sorting by agents in the table groups (#4323)

* Added sortable by agent count option to the groups table

* Added changelog entry

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 9079f07)

Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
yenienserrano added a commit that referenced this pull request Sep 2, 2022
Sorting by agents in the table groups (#4323)

* Added sortable by agent count option to the groups table

* Added changelog entry

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 9079f07)

Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
yenienserrano added a commit that referenced this pull request Sep 6, 2022
Sorting by agents in the table groups (#4323)

* Added sortable by agent count option to the groups table

* Added changelog entry

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 9079f07)

Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow sorting by Agents column in the table of Management/Groups
4 participants