-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting by agents in the table groups #4323
Merged
AlexRuiz7
merged 3 commits into
4.4-7.10
from
fix/3950-sorting-by-agents-in-the-table-groups
Jul 18, 2022
Merged
Sorting by agents in the table groups #4323
AlexRuiz7
merged 3 commits into
4.4-7.10
from
fix/3950-sorting-by-agents-in-the-table-groups
Jul 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asteriscos
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔️
chantal-kelm
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AlexRuiz7
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM!
github-actions bot
pushed a commit
that referenced
this pull request
Jul 18, 2022
* Added sortable by agent count option to the groups table * Added changelog entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 9079f07)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 18, 2022
* Added sortable by agent count option to the groups table * Added changelog entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 9079f07)
AlexRuiz7
pushed a commit
that referenced
this pull request
Jul 18, 2022
Sorting by agents in the table groups (#4323) * Added sortable by agent count option to the groups table * Added changelog entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 9079f07) Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
AlexRuiz7
pushed a commit
that referenced
this pull request
Jul 18, 2022
Sorting by agents in the table groups (#4323) * Added sortable by agent count option to the groups table * Added changelog entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 9079f07) Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
yenienserrano
added a commit
that referenced
this pull request
Sep 2, 2022
Sorting by agents in the table groups (#4323) * Added sortable by agent count option to the groups table * Added changelog entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 9079f07) Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
yenienserrano
added a commit
that referenced
this pull request
Sep 6, 2022
Sorting by agents in the table groups (#4323) * Added sortable by agent count option to the groups table * Added changelog entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 9079f07) Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added the option to sort by agents in the group table.
Issue:
Agents
column in the table ofManagement/Groups
#3950Preconditions:
Have more than 1 group with different numbers of agents
Test:
Screenshot: