-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix creating PDF reports in x-pack without authentication context #4358
Merged
Desvelao
merged 3 commits into
4.3-7.10
from
fix/set-hashUsername-in-xpack-without-authcontext
Aug 4, 2022
Merged
Fix creating PDF reports in x-pack without authentication context #4358
Desvelao
merged 3 commits into
4.3-7.10
from
fix/set-hashUsername-in-xpack-without-authcontext
Aug 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review
Code ✔️
Test ✔️
|
Machi3mfl
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ✅
Test ✅
github-actions bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
) * Added default hashUsername to xpack without authContext * changelog: add PR entry Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com> (cherry picked from commit 72af12c)
Desvelao
pushed a commit
that referenced
this pull request
Aug 4, 2022
…tication context (#4379) Fix creating PDF reports in x-pack without authentication context (#4358) * Added default hashUsername to xpack without authContext * changelog: add PR entry Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com> (cherry picked from commit 72af12c) Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes when x-pack is detected with no
authContext
available and nohashUsername
is provided. Therefore in this kind of context, creating PDF reports fails.