Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed searchbar error on SCA Inventory table #4367

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Fixed searchbar error on SCA Inventory table #4367

merged 2 commits into from
Aug 4, 2022

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Jul 29, 2022 •
edited
Loading

Hi Team,
This PR resolves an issue occurring on the SCA Inventory Table Searchbar when we select a field of the suggestion list that doesn't exist in the table data rendered.
I added validations for the suggestions list item. Now the suggestion fields always will exist in the table preventing the current error.

Closes #4347

For Testing (Manual)

  • Do the same steps to reproduce the error (Described in issue comments).
  • Expects the error doesn't appear.

@Machi3mfl Machi3mfl self-assigned this Jul 29, 2022
@Machi3mfl Machi3mfl linked an issue Jul 29, 2022 that may be closed by this pull request
Type error filtering the CIS benchmark of a Windows agent #4347
Closed
@Mayons95
Copy link
Contributor

Mayons95 commented Aug 1, 2022

TR ✅
Screencast from 01-08-22 11:20:25.webm

@Mayons95 Mayons95 self-requested a review August 1, 2022 14:26
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Jest Test Coverage % values
Statements 6.67% ( 2431 / 36463 )
Branches 2.67% ( 755 / 28234 )
Functions 4.47% ( 398 / 8911 )
Lines 6.74% ( 2352 / 34888 )

yenienserrano
yenienserrano approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅
image

@Machi3mfl Machi3mfl merged commit ebd8208 into 4.3-7.10 Aug 4, 2022
@Machi3mfl Machi3mfl deleted the fix/4347-error-searchbar-suggestions-sca branch August 4, 2022 17:40
github-actions bot pushed a commit that referenced this pull request Aug 4, 2022
@Machi3mfl @github-actions
Fixed searchbar error on SCA Inventory table (#4367)
31bee3b 
* Fixed searchbar error on SCA Inventory table

* Added suggestion empty array in constructor

(cherry picked from commit ebd8208)
@github-actions github-actions bot mentioned this pull request Aug 4, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Aug 4, 2022
@Machi3mfl @github-actions
Fixed searchbar error on SCA Inventory table (#4367)
847a793 
* Fixed searchbar error on SCA Inventory table

* Added suggestion empty array in constructor

(cherry picked from commit ebd8208)
@github-actions github-actions bot mentioned this pull request Aug 4, 2022
Merged
AlexRuiz7 pushed a commit that referenced this pull request Aug 5, 2022
@github-actions @Machi3mfl
[Backport 4.3-7.16] Fixed searchbar error on SCA Inventory table (#4380)
5016130 
Fixed searchbar error on SCA Inventory table (#4367)

* Fixed searchbar error on SCA Inventory table

* Added suggestion empty array in constructor

(cherry picked from commit ebd8208)

Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
AlexRuiz7 pushed a commit that referenced this pull request Aug 5, 2022
@github-actions @Machi3mfl
[Backport 4.3-1.2-wzd] Fixed searchbar error on SCA Inventory table (#…
3c93bc5 
…4381)

Fixed searchbar error on SCA Inventory table (#4367)

* Fixed searchbar error on SCA Inventory table

* Added suggestion empty array in constructor

(cherry picked from commit ebd8208)

Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
@Mayons95 Mayons95 mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mayons95 Mayons95 Mayons95 approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@Machi3mfl Machi3mfl

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type error filtering the CIS benchmark of a Windows agent
3 participants
@Machi3mfl @Mayons95 @yenienserrano