Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render nested field rows in security alerts table #4428

Merged

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Aug 31, 2022

Description

This PR fixes the issue where the Dashboard / Security Alerts table was not prepared to render an array of objects as a field value. It implements the components used in Modules / Events table to analyze and render possible nested fields.

Closes #4429

Screenshot

Security Alerts table

image


Collapsed row:

image


Expanded row

image

@asteriscos asteriscos self-assigned this Aug 31, 2022
@asteriscos asteriscos linked an issue Aug 31, 2022 that may be closed by this pull request
@asteriscos asteriscos added the 4.4 label Aug 31, 2022
@asteriscos asteriscos marked this pull request as ready for review August 31, 2022 15:27
@Mayons95
Copy link
Contributor

Mayons95 commented Sep 5, 2022

TR ✔️

Screenshot from 2022-09-05 15-20-21
Screenshot from 2022-09-05 15-20-03

I think the way the information is displayed can be improved with the expand button (open button) next to the data field name and not above it

@Mayons95 Mayons95 self-requested a review September 5, 2022 18:28
Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the comment I left before

@asteriscos
Copy link
Member Author

TR heavy_check_mark

Screenshot from 2022-09-05 15-20-21 Screenshot from 2022-09-05 15-20-03

I think the way the information is displayed can be improved with the expand button (open button) next to the data field name and not above it

Thanks for the suggestion @Mayons95. The design is based on the app core Discover components to follow the same pattern and normalize the user interactions with the interface.

image

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Screenshot

image

image

Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asteriscos asteriscos merged commit b2a6c10 into 4.4-7.10 Sep 8, 2022
@asteriscos asteriscos deleted the fix/dashboard-security-alert-table-nested-fields-row branch September 8, 2022 12:44
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

The backport to 4.4-1.2-wzd failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-1.2-wzd 4.4-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.4-1.2-wzd
# Create a new branch
git switch --create backport-4428-to-4.4-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b2a6c10b5ae284bb25210e5c696750ec25efacdc
# Push it to GitHub
git push --set-upstream origin backport-4428-to-4.4-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-1.2-wzd

Then, create a pull request where the base branch is 4.4-1.2-wzd and the compare/head branch is backport-4428-to-4.4-1.2-wzd.

github-actions bot pushed a commit that referenced this pull request Sep 8, 2022
* Evaluate nested fields and render object array

* Removed text color style

* Added changelog

(cherry picked from commit b2a6c10)
AlexRuiz7 pushed a commit that referenced this pull request Sep 8, 2022
…#4466)

Render nested field rows in security alerts table (#4428)

* Evaluate nested fields and render object array

* Removed text color style

* Added changelog

(cherry picked from commit b2a6c10)

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
AlexRuiz7 pushed a commit that referenced this pull request Sep 8, 2022
* Evaluate nested fields and render object array

* Removed text color style

* Added changelog

(cherry picked from commit b2a6c10)
AlexRuiz7 added a commit that referenced this pull request Sep 8, 2022
…ble (#4470)

Render nested field rows in security alerts table (#4428)

* Evaluate nested fields and render object array

* Removed text color style

* Added changelog

(cherry picked from commit b2a6c10)

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
@Mayons95 Mayons95 mentioned this pull request Dec 7, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested fields don't display properly in Security Alerts table
4 participants