-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render nested field rows in security alerts table #4428
Render nested field rows in security alerts table #4428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please read the comment I left before
Thanks for the suggestion @Mayons95. The design is based on the app core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-1.2-wzd 4.4-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.4-1.2-wzd
# Create a new branch
git switch --create backport-4428-to-4.4-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b2a6c10b5ae284bb25210e5c696750ec25efacdc
# Push it to GitHub
git push --set-upstream origin backport-4428-to-4.4-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-1.2-wzd Then, create a pull request where the |
* Evaluate nested fields and render object array * Removed text color style * Added changelog (cherry picked from commit b2a6c10)
* Evaluate nested fields and render object array * Removed text color style * Added changelog (cherry picked from commit b2a6c10)
Description
This PR fixes the issue where the Dashboard / Security Alerts table was not prepared to render an array of objects as a field value. It implements the components used in Modules / Events table to analyze and render possible nested fields.
Closes #4429
Screenshot
Security Alerts table
Collapsed row:
Expanded row