Changed terms of Office Max Rule Level #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
TR: ✔️ LGTM ! |
Mayons95
approved these changes
Sep 14, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 14, 2022
(cherry picked from commit 02b581b)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 14, 2022
(cherry picked from commit 02b581b)
Tostti
added a commit
that referenced
this pull request
Sep 14, 2022
Tostti
added a commit
that referenced
this pull request
Sep 14, 2022
7 tasks
1 task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the main Office 365 dashboard, in which the Max Rule Level was not showing the correct value.
Changes
public/components/overview/metrics/metrics.tsxfor the office Max Rule Level to use the field rule.level instead of timestamp.Closes #4355
Screenshots
Tests
Scenario: Open the main Office 365 dashboard
Given the alerts on the specified timeframe
When the maximum alert level is defined
Then the Max Rule Level should show the correct value and match with the value shown in the
Events by severity over timegraphic