Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance and fix some GitHub actions workflows #4680

Merged
merged 4 commits into from
Oct 17, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Oct 14, 2022

Description

This pull request enhances and fixes some problems related to GitHub actions workflows

  • Create a reusable workflow that uses the prebuilt Docker images of
    development mode to mount the plugin source code and runs a command.
  • Create a workflow to build a package on demand.
  • Create a workflow to check the unit test with jest. Use the
    expected platform.
  • Create a wildcard workflow to run a command in development mode.
  • Remove duplicate workflows.

These workflows require the prebuilt Docker images.

Issues Resolved

Closes #4662

Evidence

[Provide screenshots or videos to prove this PR solves the issues]

Test

[Provide instructions to test this PR]

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Create a reusable workflow that uses the prebuit Docker images of
development mode to mount the plugin source code and run a command.
Create a workflow to build a package on demand
Create a workflow to check the linter
Create a workflow to check the unit test with jest. Enhanced to use the
expected platform.
Create a wildcard workflow to run a command in a development mode
@Desvelao Desvelao requested a review from a team as a code owner October 14, 2022 06:59
@Desvelao Desvelao self-assigned this Oct 14, 2022
@Desvelao Desvelao added the type/enhancement Enhancement issue label Oct 14, 2022
@Desvelao Desvelao changed the title Enhance and fix some workflows Enhance and fix some GitHub actions workflows Oct 14, 2022
@AlexRuiz7
Copy link
Member

Removed the file .github/workflows/check-code-integrity.yml from this PR, in 19ac902

It will be included in a pull request for #4681.

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 6.89% ( 2513 / 36484 )
Branches 2.72% ( 769 / 28224 )
Functions 4.6% ( 410 / 8920 )
Lines 6.97% ( 2432 / 34907 )

Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexRuiz7 AlexRuiz7 merged commit abee739 into master Oct 17, 2022
@AlexRuiz7 AlexRuiz7 deleted the feat/4662-fix-enhance-actions branch October 17, 2022 14:39
github-actions bot pushed a commit that referenced this pull request Oct 17, 2022
- Create a reusable workflow that uses the prebuit Docker images of
development mode to mount the plugin source code and run a command.
- Create a workflow to build a package on demand
- Create a workflow to check the unit test with jest. Enhanced to use the
expected platform.
- Create a wildcard workflow to run a command in a development mode

* Remove .github/workflows/check-code-integrity.yml

Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit abee739)
github-actions bot pushed a commit that referenced this pull request Oct 17, 2022
- Create a reusable workflow that uses the prebuit Docker images of
development mode to mount the plugin source code and run a command.
- Create a workflow to build a package on demand
- Create a workflow to check the unit test with jest. Enhanced to use the
expected platform.
- Create a wildcard workflow to run a command in a development mode

* Remove .github/workflows/check-code-integrity.yml

Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit abee739)
@github-actions
Copy link
Contributor

The backport to stable failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-stable stable
# Navigate to the new working tree
cd .worktrees/backport-stable
# Create a new branch
git switch --create backport-4680-to-stable
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 abee739ab44af7478407b4c6c27482c001a5fd36
# Push it to GitHub
git push --set-upstream origin backport-4680-to-stable
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-stable

Then, create a pull request where the base branch is stable and the compare/head branch is backport-4680-to-stable.

github-actions bot pushed a commit that referenced this pull request Oct 17, 2022
- Create a reusable workflow that uses the prebuit Docker images of
development mode to mount the plugin source code and run a command.
- Create a workflow to build a package on demand
- Create a workflow to check the unit test with jest. Enhanced to use the
expected platform.
- Create a wildcard workflow to run a command in a development mode

* Remove .github/workflows/check-code-integrity.yml

Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit abee739)
AlexRuiz7 pushed a commit that referenced this pull request Oct 17, 2022
)

Enhance and fix some GitHub actions workflows (#4680)

- Create a reusable workflow that uses the prebuit Docker images of
development mode to mount the plugin source code and run a command.
- Create a workflow to build a package on demand
- Create a workflow to check the unit test with jest. Enhanced to use the
expected platform.
- Create a wildcard workflow to run a command in a development mode

* Remove .github/workflows/check-code-integrity.yml

Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit abee739)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
AlexRuiz7 pushed a commit that referenced this pull request Oct 17, 2022
…4693)

Enhance and fix some GitHub actions workflows (#4680)

- Create a reusable workflow that uses the prebuit Docker images of
development mode to mount the plugin source code and run a command.
- Create a workflow to build a package on demand
- Create a workflow to check the unit test with jest. Enhanced to use the
expected platform.
- Create a wildcard workflow to run a command in a development mode

* Remove .github/workflows/check-code-integrity.yml

Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit abee739)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
AlexRuiz7 pushed a commit that referenced this pull request Oct 17, 2022
)

Enhance and fix some GitHub actions workflows (#4680)

- Create a reusable workflow that uses the prebuit Docker images of
development mode to mount the plugin source code and run a command.
- Create a workflow to build a package on demand
- Create a workflow to check the unit test with jest. Enhanced to use the
expected platform.
- Create a wildcard workflow to run a command in a development mode

* Remove .github/workflows/check-code-integrity.yml

Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit abee739)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
AlexRuiz7 pushed a commit that referenced this pull request Oct 17, 2022
- Create a reusable workflow that uses the prebuit Docker images of
development mode to mount the plugin source code and run a command.
- Create a workflow to build a package on demand
- Create a workflow to check the unit test with jest. Enhanced to use the
expected platform.
- Create a wildcard workflow to run a command in a development mode

* Remove .github/workflows/check-code-integrity.yml

Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit abee739)
AlexRuiz7 added a commit that referenced this pull request Oct 17, 2022
- Create a reusable workflow that uses the prebuit Docker images of
development mode to mount the plugin source code and run a command.
- Create a workflow to build a package on demand
- Create a workflow to check the unit test with jest. Enhanced to use the
expected platform.
- Create a wildcard workflow to run a command in a development mode

* Remove .github/workflows/check-code-integrity.yml

Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit abee739)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the unit test action
3 participants