Fix styles in deploy new agent section #4830
Conversation
There was a problem hiding this comment.
We saw witch @chantal-kelm that the option for Suse 12 has the same problem as before.
chantal-kelm
changed the title
|
| .euiButtonGroup__buttons { | ||
| display: grid; | ||
| grid-template-columns: repeat(3, 1fr); | ||
| grid-template-columns: repeat(5, 1fr); | ||
| grid-gap: 10px; | ||
| padding: 0 3px; | ||
| box-shadow: none; | ||
| } |
There was a problem hiding this comment.
question: is this a class of the @elastic/eui? If it does, we should ensure only to affect the UI of the Wazuh plugin. This could be modifying the styles of plugins of the platform.
| .euiButtonGroup--medium .euiButtonGroupButton:not(:first-child), .euiButtonGroup--small .euiButtonGroupButton:not(:first-child) { | ||
| margin-left: 0 !important; | ||
|
|
||
| } |
There was a problem hiding this comment.
question: is this a class of the @elastic/eui? If it does, we should ensure only to affect the UI of the Wazuh plugin. This could be modifying the styles of plugins of the platform.
There was a problem hiding this comment.
thought: For another hand, this pull request has as its base the branch 4.4-2.3-wzd, which is a plugin compatible with Wazuh dashboard based on OpenSearch Dashboards 2.3.0. This version of OpenSearch is using a forked UI library, https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.3.0/package.json#L111, and it seems the class names are prefixed by oui instead of eui https://github.com/opensearch-project/oui/blob/1.0.0/src/components/button/button_group/_button_group_button.scss#L122. Is these styles applying?
There was a problem hiding this comment.
thought: For another hand, this pull request has as its base the branch
4.4-2.3-wzd, which is a plugin compatible with Wazuh dashboard based on OpenSearch Dashboards 2.3.0. This version of OpenSearch is using a forked UI library, https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.3.0/package.json#L111, and it seems the class names are prefixed byouiinstead ofeuihttps://github.com/opensearch-project/oui/blob/1.0.0/src/components/button/button_group/_button_group_button.scss#L122. Is these styles applying?
I was testing the branch and it is working. It seems that the UI library contains components from @elastic/eui and oui components.
Anyways, we should ensure that the modified styles only happen in the Wazuh plugin.
| display: grid; | ||
| grid-template-columns: repeat(5, 1fr); | ||
| grid-gap: 10px; | ||
| .message { |
There was a problem hiding this comment.
nitpick: this class name is generic and could have conflicts with the styles of other plugins, we should use scoped names, for example prefixing it with wz, wazuh.
Description
In Wazuh info, in the 'Deploy new agent' section, the OS and versions were not displayed correctly.
Evidence
This is what Wazuh Info used to look like:
This is what it looks like now:
Steps to test:
*Go to the Agents tab
*Click on the 'Deploy new agent' button.
*Verify that the styles are displayed correctly.