Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 4.4-7.16] Enhance the getConfiguration backend service #5431

Merged
merged 3 commits into from
May 11, 2023

Conversation

Desvelao
Copy link
Member

Backport 6290e99 from #5428

* fix(enhance): enhance the the backend service to get the plugin configuration

- Enhance the backend service to get the plugin configuration
- Tests:
  - Add testing for the getConfiguration service
  - Add test to ensure the `GET /utils/configuration` returns the expected host
    response

* changelog: add pull request entry

* changelog: fix changelog

* Fix get configuration test unlink command error

* fix: fix comment on unit test

---------

Co-authored-by: Maximiliano Ibarra <maximiliano.ibarra@wazuh.com>
(cherry picked from commit 6290e99)
@Desvelao Desvelao requested a review from a team as a code owner May 11, 2023 06:26
@Desvelao Desvelao self-assigned this May 11, 2023
@Desvelao Desvelao linked an issue May 11, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.61% ( 3258 / 37854 )
Branches 4.4% ( 1287 / 29232 )
Functions 7.48% ( 703 / 9400 )
Lines 8.68% ( 3143 / 36204 )

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

image

@asteriscos asteriscos merged commit 3c3a4b6 into 4.4-7.16 May 11, 2023
@asteriscos asteriscos deleted the backport-5428-to-4.4-7.16 branch May 11, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the getConfiguration backend service
3 participants