Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inventory unit tests #5829

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Fix inventory unit tests #5829

merged 2 commits into from
Aug 29, 2023

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Aug 29, 2023 •
edited
Loading

Description

Hi team,
this PR fixes a few unit tests that stopped working due to new features synced from 4.6.0 branch.

Issues Resolved

#5819

Test

These unit tests must pass

  • inventory.test.tsx
  • agent-table.test.tsx

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Aug 29, 2023
@asteriscos asteriscos requested a review from a team as a code owner August 29, 2023 12:57
Desvelao
Desvelao approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yenienserrano
yenienserrano approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.72% ( 4041 / 34476 )
Branches 7.96% ( 1855 / 23283 )
Functions 11.22% ( 925 / 8244 )
Lines 11.91% ( 3929 / 32978 )

@asteriscos asteriscos merged commit 796066c into 4.7.0 Aug 29, 2023
@asteriscos asteriscos deleted the fix/5819-fix-unit-tests-inventory-and-agents-table branch August 29, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asteriscos @Desvelao @yenienserrano