Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit filter from search bar UI #6174

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Remove implicit filter from search bar UI #6174

merged 4 commits into from
Nov 30, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Nov 29, 2023 •
edited
Loading

Description

This pull request removes the implicit filter from the search bar UI.

Issues Resolved

#6172

Evidence

image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Ensure the implicit filter is not displayed for WQL in the search bar UI ⚫ ⚫ ⚫

Details

⚫ Ensure the implicit filter is not displayed for WQL in the search bar UI

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao requested a review from a team as a code owner November 29, 2023 07:24
@Desvelao Desvelao self-assigned this Nov 29, 2023
@Desvelao Desvelao linked an issue Nov 29, 2023 that may be closed by this pull request
Remove the manager filter indicator from the search bar #6172
Closed
@Tostti Tostti self-requested a review November 29, 2023 14:18
@Tostti
Copy link
Member

Tostti commented Nov 29, 2023

Test 🟢

image

Tostti
Tostti approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test ✔️
CR ✔️

LGTM

@chantal-kelm chantal-kelm self-requested a review November 30, 2023 13:40
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.38% ( 185 / 865 )
Branches 18.07% ( 79 / 437 )
Functions 14.22% ( 36 / 253 )
Lines 21.61% ( 182 / 842 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.68% ( 171 / 223 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.68% ( 171 / 223 )

chantal-kelm
chantal-kelm approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

image

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.01% ( 4137 / 34439 )
Branches 8.12% ( 1883 / 23162 )
Functions 11.39% ( 934 / 8193 )
Lines 12.18% ( 4026 / 33035 )

@asteriscos asteriscos merged commit 2b875e8 into 4.8.0 Nov 30, 2023
4 checks passed
@asteriscos asteriscos deleted the change/6172-remove-implicit-filter-from-search-bar-ui branch November 30, 2023 16:16
@asteriscos asteriscos mentioned this pull request Dec 14, 2023
Closed
1 task
@asteriscos asteriscos mentioned this pull request Jan 15, 2024
Closed
1 task
@lucianogorza lucianogorza mentioned this pull request Feb 6, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@Tostti Tostti Tostti approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the manager filter indicator from the search bar
4 participants
@Desvelao @Tostti @chantal-kelm @asteriscos