Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error navigating back to agent #6224

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fix error navigating back to agent #6224

merged 2 commits into from
Dec 15, 2023

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Dec 15, 2023 •
edited
Loading

Description

This PR aims to solve a problem with the agents. When a user access an agent information clicking on Most active agent or Last registered agent, after navigating to another site on the app it can't return with the browser's back button.
This doesn't happen when the agent is accessed through the agents table

Issues Resolved

#6211

Evidence

Video_2023-12-15_09-14-44.mp4

Test

  1. Have an environment with a real manager and an agent registered
  2. Navigate to Wazuh/Agents and click on the Last registered agent
  3. Navigate to Wazuh/Tools/Api console and run any query
  4. Click the browser's back button. It should return to the agent detail.
  5. Repeat steps 2 to 4, clicking on the Most active agent instead of last registered
  6. Repeat steps 2 to 4, clicking on an agent in the agents table.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti linked an issue Dec 15, 2023 that may be closed by this pull request
TypeError and Could not fetch data for this agent messages found after using the API Console #6211
Closed
@github-actions GitHub Actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.73% ( 4048 / 34507 )
Branches 7.96% ( 1855 / 23299 )
Functions 11.26% ( 930 / 8257 )
Lines 11.91% ( 3937 / 33047 )

@Tostti Tostti marked this pull request as ready for review December 15, 2023 12:34
@Tostti Tostti requested a review from a team as a code owner December 15, 2023 12:34
@yenienserrano yenienserrano self-requested a review December 15, 2023 12:40
asteriscos
asteriscos approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Peek 2023-12-15 14-06

yenienserrano
yenienserrano approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

image

@Tostti Tostti merged commit 9a92c37 into 4.7.2 Dec 15, 2023
2 checks passed
@Tostti Tostti deleted the 6211-fix-error-navigating-back-agent branch December 15, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError and Could not fetch data for this agent messages found after using the API Console
3 participants
@Tostti @asteriscos @yenienserrano