Fix refreshing index pattern fields does not include the scripted fields #6237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced custom service logic for a similar one to the Dashboards Management/Index pattern of the platform - Removed the ability to define fields that are not fields from the indices that match the index pattern or scripted fields
- Use a more low level logic to update the index pattern fields taking in account the scripted fields - The SavedObjects.refreshIndexPattern now throws an error when something fails instead of return the error message - Display a warning in the check fields or when refreshing the index pattern of the default configurated index pattern of the plugins
TestLegend: UI
Details 🟢 Ensuring a scripted field is added to the index pattern, run or force the alerts pattern check is run. The scripted field should not be lost (use Discover or Events tab to check it is there)Chrome - 🟢
Firefox - ⚫ Safari - ⚫ 🟢 Ensuring a scripted field is added to the index pattern, use the index pattern selector to select the index pattern with the scripted field. The scripted field should not be lost (use Discover or Events tab to check it is there)Chrome - 🟢
Firefox - ⚫ Safari - ⚫ 🟢 Ensuring a scripted field is added to the index pattern, use the index pattern selector to select the index pattern with the scripted field. Index data with new fields for the index pattern (you can use some category of sample data), then go to Events tab and open an alert that contain a new field. Then use the Reload button of the toast. The scripted field should not be lost (use Discover or Events tab to check it is there)Chrome - 🟢
Firefox - ⚫ Safari - ⚫ |
|
|
|
TestLegend: UI
Details 🟢 Ensuring a scripted field is added to the index pattern, run or force the alerts pattern check is run. The scripted field should not be lost (use Discover or Events tab to check it is there)Chrome - 🟢
Firefox - ⚫ Safari - ⚫ 🟢 Ensuring a scripted field is added to the index pattern, use the index pattern selector to select the index pattern with the scripted field. The scripted field should not be lost (use Discover or Events tab to check it is there)Chrome - 🟢
Firefox - ⚫ Safari - ⚫ 🟢 Ensuring a scripted field is added to the index pattern, use the index pattern selector to select the index pattern with the scripted field. Index data with new fields for the index pattern (you can use some category of sample data), then go to Events tab and open an alert that contain a new field. Then use the Reload button of the toast. The scripted field should not be lost (use Discover or Events tab to check it is there)Chrome - 🟢
Firefox - ⚫ Safari - ⚫ |
asteriscos
deleted the
fix/3632-refresh-index-pattern-fields-scripted-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes that refreshing the index pattern fields does not include the scripted fields.
Changes:
Management/Index pattern of the platform
in account the scripted fields
something fails instead of return the error message
indices that match the index pattern or scripted fields
pattern of the default configurated index pattern of the plugins
Issues Resolved
#3632
Evidence
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ Ensuring a scripted field is added to the index pattern, run or force the alerts pattern check is run. The scripted field should not be lost (use Discover or Events tab to check it is there)
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Ensuring a scripted field is added to the index pattern, use the index pattern selector to select the index pattern with the scripted field. The scripted field should not be lost (use Discover or Events tab to check it is there)
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Ensuring a scripted field is added to the index pattern, use the index pattern selector to select the index pattern with the scripted field. Index data with new fields for the index pattern (you can use some category of sample data), then go to Events tab and open an alert that contain a new field. Then use the Reload button of the toast. The scripted field should not be lost (use Discover or Events tab to check it is there)
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest