Fix deploy new agent filters #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbiset
previously approved these changes
Jan 16, 2024
There was a problem hiding this comment.
CR: 🟢
Test 🟢
The following examples were tested:
1- Test 1
- Description: Valid hostname
- Value: myserver123
- Passed test: 🟢
2- Test 2
- Description: Hostname with special characters (not allowed)
- Value: server@home
- Passed test: 🟢
3- Test 3
- Description: Hostname with length less than limit
- Value: thisisaverylonghostnamethatismorethan63characterslong
- Passed test: 🟢
4- Test 4
- Description: Hostname with length greater than limit
- Value: asdfasdfaasdfasdfasdfasdfasdfdsadfdsadfdsadfdsadfdsssdddaaasss
- Passed test: 🟢
5- Test 5
- Description: Valid domain
- Value: example.com
- Passed test: 🟢
6- Test 6
- Description: Domain with subdomains
- Value: subdomain1.subdomain2.example.com
- Passed test: 🟢
7- Test 7
- Description: Valid IPv4
- Value: 192.168.1.1
- Passed test: 🟢
8- Test 8
- Description: IPv4 with octet greater than limit
- Value: 256.168.1.1
- Passed test: 🟢 (A label can contain only numbers)
9- Test 9
- Description: Valid IPv6
- Value: 2001:0db8:85a3:0000:0000:8a2e:0370:7334
- Passed test: 🟢
10- Test 10
- Description: Unexpanded Uncompressed IPv6
- Value: 2001:db8:85a3:0:0:8a2e:370:7334
- Passed test: 🟢
11- Test 11
- Description: Expanded Uncompressed IPv6
- Value: 2001:0db8:85a3:0000:0000:8a2e:0370:7334
- Passed test: 🟢
asteriscos
previously approved these changes
Jan 16, 2024
asteriscos
previously approved these changes
Jan 16, 2024
jbiset
approved these changes
Jan 16, 2024
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix an error on which the
Deploy New Agentsection did not allow to specify a hostname as server addressIssues Resolved
#6311
Evidence
Test
The allowed options are:
Note: A non valid IPv4 (i.e. 280.240.1.300) should be considered valid, as it matches the rules to be a domain (alphanumeric labels with 1-63 characters)
Check List
yarn test:jest