Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltip to most active agent label #6364

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Add tooltip to most active agent label #6364

merged 5 commits into from
Jan 24, 2024

Conversation

yenienserrano
Copy link
Member

Description

The label of the last registered agent is changed to the Last enrolled agent

An information icon with a tooltip is added to the most active agent

Issues Resolved

Evidence

image

Test

  1. Navigate to Endpoint summary
  2. Look at the label change
  3. Look at the icon and the tooltip

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner January 23, 2024 16:47
@yenienserrano yenienserrano linked an issue Jan 23, 2024 that may be closed by this pull request
Add tooltip to most active agent label #6358
Closed
2 tasks
lucianogorza
lucianogorza approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image

Tostti
Tostti approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

image

Test ✅
CR ✅

LGTM

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.18% ( 186 / 878 )
Branches 17.99% ( 79 / 439 )
Functions 14% ( 36 / 257 )
Lines 21.4% ( 183 / 855 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 57.42% ( 58 / 101 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.2% ( 4202 / 34418 )
Branches 8.25% ( 1908 / 23118 )
Functions 11.71% ( 958 / 8176 )
Lines 12.38% ( 4087 / 33010 )

@asteriscos asteriscos changed the title 6358 add tooltip to most active agent label Add tooltip to most active agent label Jan 24, 2024
@asteriscos asteriscos merged commit c15c13e into 4.8.0 Jan 24, 2024
4 checks passed
@asteriscos asteriscos deleted the 6358-add-tooltip-to-most-active-agent-label branch January 24, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianogorza lucianogorza lucianogorza approved these changes

@Tostti Tostti Tostti approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tooltip to most active agent label
4 participants
@yenienserrano @Tostti @lucianogorza @asteriscos