Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MITRE ATT&CK error handling #6431

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Feb 19, 2024

Description

The error that occurred when the API did not return information has been fixed.

Issues Resolved

Improve MITRE ATT&CK Framework tab error handling #6404

Evidence

image

Test

Test Chrome Firefox Safari
MITRE ATT&CK > Framework refresh button don't spawn a error pop-up when the API did not return information
MITRE ATT&CK > Framework refresh button don't spawn a error pop-up when the API did not return information

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz requested a review from a team as a code owner February 19, 2024 15:55
@JuanGarriuz JuanGarriuz self-assigned this Feb 19, 2024
@JuanGarriuz JuanGarriuz linked an issue Feb 19, 2024 that may be closed by this pull request
yenienserrano
yenienserrano previously approved these changes Feb 19, 2024
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

image

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Test

Test Chrome Firefox Safari
MITRE ATT&CK > Framework refresh button don't spawn a error pop-up 🟢
🟢 MITRE ATT&CK > Framework refresh button don't spawn a error pop-up

image

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.13% ( 4209 / 34686 )
Branches 8.2% ( 1907 / 23247 )
Functions 11.57% ( 956 / 8261 )
Lines 12.3% ( 4097 / 33287 )

@Desvelao Desvelao merged commit 8e0bc87 into 4.8.0 Feb 20, 2024
4 checks passed
@Desvelao Desvelao deleted the feat/6404-improve-mitre-attack-error-handling branch February 20, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve MITRE ATT&CK Framework tab error handling
3 participants