Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package test #6508

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Add package test #6508

merged 2 commits into from
Mar 15, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Mar 13, 2024 •
edited
Loading

Description

Adds installation test of newly created packages in the corresponding version of Opensearch Dashboards

Issues Resolved

#6411

Evidence

if you can install the plugins the test passes
image

Final package creation should work fine when test passes
image

Final package creation may not work properly when test fails
Captura de pantalla 2024-03-13 a las 9 52 10 a  m

Test

Execute the manual build action, and it should pass if the plugins are installed.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano mentioned this pull request Mar 13, 2024
Closed
5 tasks
@yenienserrano yenienserrano self-assigned this Mar 13, 2024
@yenienserrano yenienserrano marked this pull request as ready for review March 13, 2024 18:18
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 28.94% ( 286 / 988 )
Branches 26.22% ( 107 / 408 )
Functions 26.87% ( 86 / 320 )
Lines 28.68% ( 278 / 969 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 11.83% ( 4093 / 34584 )
Branches 7.49% ( 1697 / 22644 )
Functions 10.5% ( 862 / 8206 )
Lines 12.02% ( 3986 / 33147 )

Tostti
Tostti approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asteriscos asteriscos self-requested a review March 15, 2024 15:07
asteriscos
asteriscos approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

image

@asteriscos asteriscos merged commit be39ae4 into 4.9.0 Mar 15, 2024
11 of 12 checks passed
@asteriscos asteriscos deleted the 6411-create-plugins-test-after-build branch March 15, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tostti Tostti Tostti approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yenienserrano @asteriscos @Tostti