Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix height of Home overview cards #6510

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Fix height of Home overview cards #6510

merged 2 commits into from
Mar 15, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Mar 13, 2024 •
edited
Loading

Description

This PR adds a class to the RedirectAppLinks component in the Home cards link to make the height even in each row.

Issues Resolved

Evidence

screencapture-localhost-5601-app-wz-home-2024-03-13-18_13_30

Test

  • Go to the Home page
  • Check each card's height is even in the category rows

Check List

  • All tests pass
    • yarn test:jest
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Mar 13, 2024
yenienserrano
yenienserrano previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@JuanGarriuz JuanGarriuz self-requested a review March 15, 2024 10:33
JuanGarriuz
JuanGarriuz previously approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

image

@asteriscos asteriscos dismissed stale reviews from JuanGarriuz and yenienserrano via 8939235 March 15, 2024 11:03
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.13% ( 4210 / 34699 )
Branches 8.2% ( 1907 / 23256 )
Functions 11.57% ( 957 / 8267 )
Lines 12.3% ( 4098 / 33300 )

@asteriscos asteriscos merged commit a708474 into 4.8.0 Mar 15, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/height-home-overview-cards-6509 branch March 15, 2024 11:12
@asteriscos asteriscos mentioned this pull request Apr 9, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@yenienserrano yenienserrano yenienserrano left review comments

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asteriscos @yenienserrano @JuanGarriuz