-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standard modules filters management #6534
Add standard modules filters management #6534
Conversation
Test casesGlobal
Grabacion.de.pantalla.2024-04-04.a.las.8.53.13.a.m.movDashboard tab
Inventory tab
Events tab (Discover)Search bar
Histogram chart
Data grid
|
Test casesGlobal
Chrome 🟢Global1_Chrome.webmFirefox 🟢Global1_Firefox.webm
Chrome 🟢Global1_Chrome.webmFirefox 🟢Global1_Firefox.webm
Chrome 🟢Global3_Chrome.webmFirefox 🟢Global3_Firefox.webm
Chrome 🟢Global6_Chrome.webmFirefox 🟢Global6_Firefox.webm
Chrome 🟢Global8_Chrome.webmFirefox 🟢Global8_Firefox.webmDashboard tab
Chrome 🟢Dashboard1_Chrome.webmFirefox 🟢Dashboard1_Firefox.webm
Chrome 🟢Dashboard2_Chrome.webmFirefox 🟢Dashboard2_Firefox.webm
Chrome 🟢Dashboard3_Chrome.webmFirefox 🟢Dashboard3_Firefox.webm
Inventory tab
Chrome 🟢Inventory1_Chrome.webmFirefox 🟢Inventory1_Firefox.webm
Chrome 🟢Inventory3_Chrome.webmFirefox 🟢Inventory3_Firefox.webm
Chrome 🟢Inventory4_Chrome.webmFirefox 🟢Inventory4_FIrefox.webm
Chrome 🟢Inventory5_Chrome.webmFirefox 🟢Inventory5_Firefox.webm
When you move a column to the right, then if you want to move it to the left it doesn't work. In the same way in reverse. Chrome 🟡Inventory7_Chrome.webmFirefox 🟡Inventory7_Firefox.webm
Chrome 🟢Inventory8_Chrome.webmFirefox 🟢Inventory8_Firefox.webmEvents tab (Discover)Search bar
Chrome 🟢Events1_Chrome.webmFirefox 🟢Events1_Firefox.webm
Chrome 🟢Events2_Chrome.webmFirefox 🟢Events2_Firefox.webm
Chrome 🟢Events3_Chrome.webmFirefox 🟢Events3_Firefox.webm
**When a saved query is applied and the Chrome 🟡Events5_Chrome.webmFirefox 🟡Events5_Firefox.webmHistogram chart
Chrome 🟢Histogram1_Chrome.webmFirefox 🟢Histogram1_Firefox.webm
Chrome 🟢Histogram2_Chrome.webmFirefox 🟢Histogram2_Firefox.webmData grid
In both Chrome and Firefox, moving columns from the header does not work correctly. Chrome 🟡DataGrid1_Chrome.webmFirefox 🟡DataGrid1_Firefox.webm
Chrome 🟢DataGrid1_Chrome.webmFirefox 🟢DataGrid1_Firefox.webm
Chrome 🟢DataGrid3_Chrome.webmFirefox 🟢DataGrid3_Firefox.webm |
...components/common/data-source/components/wz-data-source-selector/wz-data-source-selector.tsx
Outdated
Show resolved
Hide resolved
...components/common/data-source/components/wz-data-source-selector/wz-data-source-selector.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/components/common/data-source/hooks/use-data-source.ts
Outdated
Show resolved
Hide resolved
plugins/main/public/components/common/data-source/hooks/use-data-source.test.ts
Outdated
Show resolved
Hide resolved
plugins/main/public/components/common/data-source/hooks/use-data-source.test.ts
Outdated
Show resolved
Hide resolved
plugins/main/public/components/common/data-source/pattern/pattern-data-source-filter-manager.ts
Outdated
Show resolved
Hide resolved
plugins/main/public/components/common/data-source/pattern/pattern-data-source-filter-manager.ts
Outdated
Show resolved
Hide resolved
...ponents/common/data-source/pattern/vulnerabilities/vulnerabilities-data-source-repository.ts
Show resolved
Hide resolved
plugins/main/public/components/overview/vulnerabilities/dashboards/inventory/inventory.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/components/common/search-bar/use-search-bar.ts
Outdated
Show resolved
Hide resolved
|
|
|
Thanks @yenienserrano. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: 🟢
Test UI 🟢 (with details 🟡 )
Taking into account that the tests marked with yellow are non-breaking details, this PR is approved
Description
This PR, adds a standard solution to manage the filters and fetching data using the
Data Source
added concept.The solution is applied in the vulnerability detection module.
Issues Resolved
Closes #6499
Evidence
Screen.Recording.2024-03-27.at.16.55.26.mov
Test cases
Global
Screen.Recording.2024-03-27.at.16.56.57.mov
Screen.Recording.2024-03-27.at.16.56.57.mov
Screen.Recording.2024-03-27.at.17.03.24.mov
Screen.Recording.2024-03-31.at.12.15.01.mov
Screen.Recording.2024-03-31.at.12.16.16.mov
Screen.Recording.2024-03-31.at.12.18.52.mov
Enable/disable the hideManagerAlerts settings on App Settings
Screen.Recording.2024-03-31.at.12.33.11.mov
Screen.Recording.2024-04-03.at.14.17.47.mov
Dashboard tab
Screen.Recording.2024-03-27.at.17.05.36.mov
Screen.Recording.2024-03-27.at.17.06.10.mov
Inventory tab
Screen.Recording.2024-03-27.at.17.10.03.mov
Screen.Recording.2024-03-27.at.17.09.13.mov
Screen.Recording.2024-03-27.at.17.10.35.mov
Screen.Recording.2024-03-27.at.17.12.12.mov
Screen.Recording.2024-03-27.at.17.13.29.mov
Screen.Recording.2024-03-27.at.17.13.29.mov
Screen.Recording.2024-03-27.at.17.13.29.mov
Screen.Recording.2024-03-27.at.17.16.28.mov
Events tab (Discover)
Search bar
add filter
featureNo results match your search criteria
message)saved queries
feature (Check saved queries CRUD)Screen.Recording.2024-03-31.at.11.53.54.mov
add filter
featureScreen.Recording.2024-03-31.at.11.54.46.mov
Screen.Recording.2024-03-31.at.12.03.49.mov
No results match your search criteria
message)Screen.Recording.2024-03-31.at.12.04.32.mov
saved queries
feature (Check saved queries CRUD)Screen.Recording.2024-03-31.at.12.05.04.mov
Histogram chart
Screen.Recording.2024-03-31.at.12.07.11.mov
Screen.Recording.2024-03-31.at.12.09.21.mov
Data grid
Screen.Recording.2024-03-31.at.12.09.52.mov
Screen.Recording.2024-03-31.at.12.11.11.mov
Screen.Recording.2024-03-31.at.12.12.45.mov
Check List
yarn test:jest