Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Develop logic of a new index for the fim module (#6226)" #6601

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Revert "Develop logic of a new index for the fim module (#6226)" #6601

merged 1 commit into from
Apr 19, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Apr 18, 2024 •
edited
Loading

This reverts commit 72289d5.

Description

Changes made to support the fim index pattern are reverted.

Issues Resolved

Evidence

image image image

Test

Check that the FIM view renders the old dashboards.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Apr 18, 2024
@yenienserrano yenienserrano linked an issue Apr 18, 2024 that may be closed by this pull request
[Rollback] Refactor FIM dashboard #6600
Closed
@JuanGarriuz JuanGarriuz self-requested a review April 19, 2024 09:31
@JuanGarriuz
Copy link
Member

Test

Evidence

Check that the FIM view renders the old dashboards.

image
image

JuanGarriuz
JuanGarriuz approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Machi3mfl
Machi3mfl approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR: ✅
CR: ✅

Screen.Recording.2024-04-19.at.10.36.42.mov
Screen.Recording.2024-04-19.at.10.37.58.mov

@Tostti Tostti merged commit 723039a into 4.9.0 Apr 19, 2024
@Tostti Tostti deleted the 6600-rollback-refactor-fim-dashboard branch April 19, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Rollback] Refactor FIM dashboard
4 participants
@yenienserrano @JuanGarriuz @Machi3mfl @Tostti