Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add only active agents guard for configuration #6617

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Add only active agents guard for configuration #6617

merged 4 commits into from
Apr 24, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Apr 24, 2024 •
edited
Loading

Description

This pull request fixes a disconnected agent exception when accessing the agent log collection or integrity monitoring configuration.

Changes made:

  • Handle log collector and integrity monitoring falsy values
  • Add HOC guard validating the agent is active for the configuration view

Issues Resolved

Closes #6615

Evidence

image

Test

  • Register a real agent and wait until it is active
  • Disconnect the agent
  • Go to Endpoints Summary
  • Select the disconnected agent
  • Go to Configuration
  • Verify the view can only be used with active agents

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Apr 24, 2024
@asteriscos asteriscos linked an issue Apr 24, 2024 that may be closed by this pull request
Disconnected agent log collection exception #6615
Closed
@Desvelao
Copy link
Member

Test 🟢

image

@asteriscos asteriscos changed the title Handle log collector and integrity monitoring falsy values Add only active agents guard for configuration Apr 24, 2024
Desvelao
Desvelao approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yenienserrano
yenienserrano approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅
image

@asteriscos asteriscos merged commit a297910 into 4.8.0 Apr 24, 2024
1 check passed
@asteriscos asteriscos deleted the fix/disconnected-agent-log-collection-exception-6615 branch April 24, 2024 15:30
@asteriscos asteriscos mentioned this pull request May 3, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disconnected agent log collection exception
3 participants
@asteriscos @Desvelao @yenienserrano