Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove config-handler angularJS service #6631

Merged
merged 3 commits into from
May 2, 2024
Merged

Remove config-handler angularJS service #6631

merged 3 commits into from
May 2, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Apr 29, 2024 •
edited
Loading

Description

The goal of this pull request is to refactor the config-handler.js angularJS service, but since it's no longer being used we will remove it.

Issues Resolved

Closes #6623

Evidence

image

Test

  • Check the deleted files are no longer imported of used by any other component.
  • Go to Server Management -> Settings
  • Click en Edit configuration
  • Make changes to the cluster mode, for example
  • Save the changes and restar de Wazuh server using Restart manager-node button
  • Verify the configuration is applied correctly

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Apr 29, 2024
@asteriscos asteriscos linked an issue Apr 29, 2024 that may be closed by this pull request
[Remove discover] Refactor AngularJS config-handler.js #6623
Closed
@lucianogorza lucianogorza self-requested a review April 29, 2024 20:35
lucianogorza
lucianogorza approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

🟢 Check the deleted files are no longer imported of used by any other component

image

🟢 Edit server configuration
change-configuration.webm

image

@JuanGarriuz JuanGarriuz self-requested a review April 30, 2024 09:50
@JuanGarriuz
Copy link
Member

Test

🟢 Check the deleted files are no longer imported or used by any other component

image

🟢 Edit server configuration

image
image
image
image

JuanGarriuz
JuanGarriuz approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@asteriscos asteriscos merged commit eff2af2 into 4.9.0 May 2, 2024
1 check passed
@asteriscos asteriscos deleted the remove/angularjs-config-handler-6623 branch May 2, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@lucianogorza lucianogorza lucianogorza approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Remove discover] Refactor AngularJS config-handler.js
3 participants
@asteriscos @JuanGarriuz @lucianogorza