-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix legends in visualizations #6632
Merged
asteriscos
merged 5 commits into
4.8.0
from
enhance/refine-dashboards-visualizations-6628
May 2, 2024
Merged
Fix legends in visualizations #6632
asteriscos
merged 5 commits into
4.8.0
from
enhance/refine-dashboards-visualizations-6628
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
asteriscos
changed the title
Remove count label and PCI-DSS-Requirements-over-time redundant visua…
Fix legends in visualizations
May 2, 2024
Desvelao
reviewed
May 2, 2024
Desvelao
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
JuanGarriuz
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main goal of this pull request is to remove all the
Count
legends (when the data is not aggregated by any field) in the visualizations because it's not useful.The changes made were:
rule.pci_dss
Issues Resolved
Closes #6628
Tests & Evidence
PCI DSS
Top 10 PCI DSS requirements
visualization byrule.pci_dss
Top requirements over time
visualizationGoogle Cloud
With a pinned agent
GCP alerts evolution
visualization and theAuth answer count
visualizationHIPAA
With a pinned agent
Most common alerts
visualizationGDPR
GDPR requirements
visualizationMalware Detection
Malware activity
visualizationServer management -> Settings
Check List
yarn test:jest