Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the prop onChange is marked as requires in EuiSwitch #6735

Merged
merged 2 commits into from
May 31, 2024
Merged

Fix the prop onChange is marked as requires in EuiSwitch #6735

merged 2 commits into from
May 31, 2024

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented May 31, 2024 •
edited
Loading

Description

Fix the prop onChange is marked as requires in EuiSwitch

Issues Resolved

#6693

Evidence

image

Test

  • Go to Security and click edit on a user and see that the warning Failed prop type: The onChange property is marked as required in EuiSwitch, but its value is undefined does not appear in the console.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this May 31, 2024
@chantal-kelm chantal-kelm changed the base branch from master to 4.9.0 May 31, 2024 13:59
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 11.32% ( 3878 / 34231 )
Branches 7.54% ( 1700 / 22519 )
Functions 10.63% ( 891 / 8377 )
Lines 11.48% ( 3775 / 32859 )

asteriscos
asteriscos approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

lucianogorza
lucianogorza approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image
image

@asteriscos asteriscos merged commit 509a58d into 4.9.0 May 31, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/6693-the-prop-onChange-is-marked-as-required-in-EuiSwitch branch May 31, 2024 14:40
@asteriscos asteriscos linked an issue May 31, 2024 that may be closed by this pull request
Warnings and errors in console #6693
Closed
15 tasks
@chantal-kelm chantal-kelm mentioned this pull request May 31, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianogorza lucianogorza lucianogorza approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings and errors in console
3 participants
@chantal-kelm @asteriscos @lucianogorza