Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unexpected delay parameter on server API requests #6778

Merged

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jun 18, 2024

Description

This pull request removes the unexpected delay parameter on the server API request.

Issues Resolved

#6605

Evidence

2024/06/18 11:38:30 INFO: wazuh-wui (c09a55c48149cb4a49111deba1f87c0e) 172.18.0.9 "PUT /cluster/restart" with parameters {} and body {} done in 0.031s: 200

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Go to Rules and create or edit a rule file. Then restart the cluster. Ensure the API request to restart the cluster does not receive the delay parameter regarding the API logs

Details

⚫ Go to Rules and create or edit a rule file. Then restart the cluster. Ensure the API request to restart the cluster does not receive the `delay` parameter regarding the API logs

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this Jun 18, 2024
@Desvelao Desvelao linked an issue Jun 18, 2024 that may be closed by this pull request
@Desvelao Desvelao marked this pull request as ready for review June 18, 2024 11:51
@asteriscos asteriscos changed the title Remove unexpedted delay parameter on server API requests Remove unexpected delay parameter on server API requests Jun 18, 2024
@JuanGarriuz JuanGarriuz self-requested a review June 18, 2024 15:09
@JuanGarriuz
Copy link
Member

JuanGarriuz commented Jun 19, 2024

Test 🟢

Test Chrome Firefox Safari
Go to Rules and create or edit a rule file. Then restart the cluster. Ensure the API request to restart the cluster does not receive the delay parameter regarding the API logs 🟢 🟢

Details

🟢 Go to Rules and create or edit a rule file. Then restart the cluster. Ensure the API request to restart the cluster does not receive the `delay` parameter regarding the API logs

Chrome - 🟢

2024/06/19 07:41:15 INFO: wazuh-wui 172.23.0.10 "PUT /cluster/restart" with parameters {} and body {} done in 0.009s: 200

Firefox - 🟢

2024/06/19 07:44:30 INFO: wazuh-wui 172.23.0.10 "PUT /cluster/restart" with parameters {} and body {} done in 0.008s: 200

Safari - ⚫

JuanGarriuz
JuanGarriuz previously approved these changes Jun 19, 2024
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

LGTM!!

JuanGarriuz
JuanGarriuz previously approved these changes Jun 19, 2024
JuanGarriuz
JuanGarriuz previously approved these changes Jun 19, 2024
lucianogorza
lucianogorza previously approved these changes Jun 19, 2024
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

Test Chrome Firefox Safari
Go to Rules and create or edit a rule file. Then restart the cluster. Ensure the API request to restart the cluster does not receive the delay parameter regarding the API logs 🟢

Details

🟢 Go to Rules and create or edit a rule file. Then restart the cluster. Ensure the API request to restart the cluster does not receive the `delay` parameter regarding the API logs

Chrome - 🟢

2024/06/19 15:30:46 INFO: wazuh-wui 172.18.0.5 "GET /cluster/status" with parameters {} and body {} done in 0.036s: 200

Firefox - ⚫

Safari - ⚫

@lucianogorza lucianogorza dismissed stale reviews from JuanGarriuz and themself via f4b8cc9 June 19, 2024 15:37
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.94% ( 187 / 893 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.14% ( 184 / 870 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.3% ( 4278 / 34780 )
Branches 8.31% ( 1938 / 23294 )
Functions 11.63% ( 964 / 8284 )
Lines 12.48% ( 4168 / 33384 )

@lucianogorza lucianogorza merged commit 9c43088 into 4.8.1 Jun 19, 2024
5 checks passed
@lucianogorza lucianogorza deleted the bug/6605-remove-unused-delay-parameter-server-api-request branch June 19, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delay body parameter in PUT /cluster/restart
4 participants