-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pinned agent is not persisted on refreshing page #6790
Merged
lucianogorza
merged 3 commits into
4.9.0
from
bug/6788-keep-pinned-agent-on-refresh-page
Jun 25, 2024
Merged
Fix pinned agent is not persisted on refreshing page #6790
lucianogorza
merged 3 commits into
4.9.0
from
bug/6788-keep-pinned-agent-on-refresh-page
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asteriscos
changed the title
Fix pinned agent was not keet on refrshing page
Fix pinned agent is not persisted on refreshing page
Jun 20, 2024
JuanGarriuz
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test π’
Grabacion.2024-06-11.123352.mp4
CR π’
LGTM!!
|
|
|
jbiset
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: π’
Test UI π’
Legend:
β«: none
π’: pass
π‘: warning
π΄: fail
βͺ: not applicable
UI
Test | Chrome | Firefox | Safari |
---|---|---|---|
With a view that displays the pinned agent, refresh the page, the pinned agent should keep pinned. | π’ | π’ | β« |
Details
π’ With a view that displays the pinned agent, refresh the page, the pinned agent should keep pinned.
Chrome - π’
Evidence_Chrome.webm
Firefox - π’
Evidence_Firefox.webm
Safari - β«
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a problem of pinned agent is not kept when refreshing the page.
Issues Resolved
#6788
Evidence
Test
Legend:
β«: none
π’: pass
π‘: warning
π΄: fail
βͺ: not applicable
UI
Details
β« With a view that displays the pinned agent, refresh the page, the pinned agent should keep pinned.
Chrome - β«
Firefox - β«
Safari - β«
Check List
yarn test:jest