Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed donut card legend #6832

Conversation

jbiset
Copy link
Member

@jbiset jbiset commented Jul 16, 2024

Description

This PR fixes the legend of the donut-card component to adjust the available space the legend has, allowing more text to be rendered.

Issues Resolved

Evidence

Breakpoint 425px

image

Breakpoint 768px

image

Breakpoint 1024px

image

Breakpoint 1440px

image

Test

  • Go to Server management -> Endpoints Summary
  • Check that the legends of the donut cards, especially those of Agents by status, are complete.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@jbiset jbiset self-assigned this Jul 16, 2024
@jbiset jbiset marked this pull request as ready for review July 16, 2024 18:48
@yenienserrano yenienserrano self-requested a review July 18, 2024 12:43
@yenienserrano
Copy link
Member

Test

Breakpoint 425px 🟢

image

Breakpoint 768px 🟢

image

Breakpoint 1024px 🟢

image

Breakpoint 1440px 🟢

image

yenienserrano
yenienserrano previously approved these changes Jul 18, 2024
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.64% ( 3989 / 29229 )
Branches 9.1% ( 1744 / 19149 )
Functions 13.35% ( 943 / 7062 )
Lines 13.83% ( 3886 / 28091 )

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST 🟢
CR 🟢

LGTM

@Tostti Tostti merged commit fdc433e into 4.9.0 Jul 19, 2024
5 checks passed
@Tostti Tostti deleted the bug/244-never-connected-agents-by-status-reference-in-endpoints-summary branch July 19, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Never connected Agents by status reference in endpoints summary displays incomplete
3 participants