-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix permalink field in Events tab in Virustotal #6839
Merged
Tostti
merged 3 commits into
4.9.0
from
bug/6838-permalink-field-is-not-clickable-in-events-table-in-virustotal
Jul 19, 2024
Merged
Fix permalink field in Events tab in Virustotal #6839
Tostti
merged 3 commits into
4.9.0
from
bug/6838-permalink-field-is-not-clickable-in-events-table-in-virustotal
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test 🟡Grabacion.2024-06-11.123352.mp4Some links redirect to the VirusTotal app. Maybe setting |
JuanGarriuz
approved these changes
Jul 18, 2024
…n-events-table-in-virustotal
|
|
|
yenienserrano
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: 🟢
Test: 🟢
Screen.Recording.2024-07-19.at.2.48.30.PM.mov
Tostti
deleted the
bug/6838-permalink-field-is-not-clickable-in-events-table-in-virustotal
branch
July 19, 2024 19:24
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
data.virustotal.permalink
column of the table in Events tab in Virustotal module. Para ello se cambia el render de ese campo usando unEuiLink
con atributos de URL externo.Issues Resolved
Evidence
data.virustotal.permalink as link
Redirected page
Evidence external link
Test
data.virustotal.permalink
column shows linksCheck List
yarn test:jest