Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permalink field in Events tab in Virustotal #6839

Conversation

jbiset
Copy link
Member

@jbiset jbiset commented Jul 17, 2024

Description

This PR fixes data.virustotal.permalink column of the table in Events tab in Virustotal module. Para ello se cambia el render de ese campo usando un EuiLink con atributos de URL externo.

Issues Resolved

Evidence

data.virustotal.permalink as link

image

Redirected page

image

Evidence external link

image

Test

  • Go to Virustotal module
  • Go to Events tab
  • Check data.virustotal.permalink column shows links
  • Chequear el correcto funcionamiento de los enlaces

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@jbiset jbiset self-assigned this Jul 17, 2024
@JuanGarriuz
Copy link
Member

Test 🟡

Grabacion.2024-06-11.123352.mp4

Some links redirect to the VirusTotal app. Maybe setting display none for empty links can solve this problem.

@JuanGarriuz JuanGarriuz self-requested a review July 18, 2024 08:17
@jbiset
Copy link
Member Author

jbiset commented Jul 18, 2024

Test 🟡

Grabacion.2024-06-11.123352.mp4
Some links redirect to the VirusTotal app. Maybe setting display none for empty links can solve this problem.

It is decided to return a - when there is no permalink as happens in the Dashboard tab table to maintain consistency.

Dashboard table

image

Events table

image

@yenienserrano yenienserrano self-requested a review July 19, 2024 12:08
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.64% ( 3989 / 29232 )
Branches 9.1% ( 1744 / 19151 )
Functions 13.35% ( 943 / 7063 )
Lines 13.83% ( 3886 / 28094 )

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Screen.Recording.2024-07-19.at.2.48.30.PM.mov

@Tostti Tostti merged commit aefa69a into 4.9.0 Jul 19, 2024
5 checks passed
@Tostti Tostti deleted the bug/6838-permalink-field-is-not-clickable-in-events-table-in-virustotal branch July 19, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permalink field is not clickable in the Events table in the Virustotal module
4 participants