Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unification the rendering of flyout columns #6848

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jul 18, 2024

Description

The rendering values of the Mitre and Security operations flyout columns are changed to the same rendering of the events table, as it is the same rendering and can be handled all from the same place.
And the rendering of the security operations requirements column is fixed.

Issues Resolved

Evidence

Security operations

image image image image image

Mitre

image

Test

  1. Navigate to the different modules of Security operations > Control
  2. Open flyouts
  3. Observe the following parameters:
  • The agent.id and agent.name are links if they are not the agent 000 that redirects to the agent view
  • The requirements if more than 1 must be separated by ,
  • the rules must be a link that redirects to the rule.
  1. Navigate to Mitre > Framework
  2. Open flyout
  3. Take into account the following parameters
  • The agent.id and agent.name are links if they are not agent 000 that redirect to agent view
  • The requirements if they are more than 1 must be separated by ,
  • the rules must be a link that redirects to the rule.
  • The technique must be a link that redirects to the technique.
  1. Navigate to sameApplication > Events

  2. Check that the links in the table work

  3. Navigate to Threat Hunting > Dashboard

  4. Check that the links in the table work:

  • Agent.id
  • Agent.name
  • rule.mitre.id
  • rule.id

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Jul 18, 2024
@yenienserrano yenienserrano linked an issue Jul 18, 2024 that may be closed by this pull request
3 tasks
jbiset
jbiset previously approved these changes Jul 19, 2024
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI: 🟢

Security operations

image

image

image

image

image

Redirect rule 503

image

Mitre

image

Redirect technique

image

@Desvelao
Copy link
Member

Tests

🟢 Security operations
image
image
image
image
image

🟢 MITRE ATTACK
image
image

Desvelao
Desvelao previously approved these changes Jul 22, 2024
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yenienserrano yenienserrano dismissed stale reviews from Desvelao and jbiset via 69c3c3b July 22, 2024 14:48
jbiset
jbiset previously approved these changes Jul 22, 2024
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Desvelao
Copy link
Member

We found a problem with the redirection of the Techniques on the MITRE ATT&CK detail flyout. This will be solved on this pull request.

jbiset
jbiset previously approved these changes Jul 24, 2024
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed new changes

CR: 🟢

Test UI: 🟢

Evidence

changes_evidence.webm

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.63% ( 3989 / 29246 )
Branches 9.1% ( 1744 / 19159 )
Functions 13.36% ( 943 / 7057 )
Lines 13.82% ( 3886 / 28110 )

Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Desvelao
Copy link
Member

LGTM!

@Desvelao Desvelao merged commit 334ea4b into 4.9.0 Jul 26, 2024
5 checks passed
@Desvelao Desvelao deleted the bug/6844-remove-redirection-to-agent-000-from-security-operations-modules branch July 26, 2024 06:48
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redirection to agent 000 from security operations modules
3 participants