-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unification the rendering of flyout columns #6848
Unification the rendering of flyout columns #6848
Conversation
…om-security-operations-modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…om-security-operations-modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…om-security-operations-modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…om-security-operations-modules
We found a problem with the redirection of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed new changes
CR: 🟢
Test UI: 🟢
Evidence
changes_evidence.webm
…om-security-operations-modules
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM! |
Description
The rendering values of the Mitre and Security operations flyout columns are changed to the same rendering of the events table, as it is the same rendering and can be handled all from the same place.
And the rendering of the security operations requirements column is fixed.
Issues Resolved
Evidence
Security operations
Mitre
Test
Navigate to sameApplication > Events
Check that the links in the table work
Navigate to Threat Hunting > Dashboard
Check that the links in the table work:
Check List
yarn test:jest